You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/15 16:10:46 UTC
[GitHub] [flink] zentol opened a new pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
zentol opened a new pull request #19103:
URL: https://github.com/apache/flink/pull/19103
This PR adds a manually-triggered github action to the build the documentation. The goal is to eventually subsume our buildbot setup in https://github.com/apache/infrastructure-bb2.
Enabling the action as a nightly build, for all relevant branches, will happen in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19103:
URL: https://github.com/apache/flink/pull/19103#discussion_r827970480
##########
File path: .github/workflows/docs.yml
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: "Build documentation"
+on:
+ workflow_dispatch:
+jobs:
+ build-documentation:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@master
+ - name: Set branch environment variable
+ run: |
+ currentBranch=$(git branch --show-current)
+
+ echo "flink_branch=${currentBranch}" >> ${GITHUB_ENV}
+
+ if [ "${currentBranch} = "master" ]; then
+ echo "flink_alias=release-1.16" >> ${GITHUB_ENV}
Review comment:
You mean like item 13 in the checklist of the `Prepare for the release` section? :)
> (major only) The documentation for the new major release is visible under https://nightlies.apache.org/flink/flink-docs-release-$SHORT_RELEASE_VERSION (after at least one doc build finishes).
Note that in terms of Flink, major refers to 1.X.0, while minor are 1.Y.X. We don't have a term for 2.x. It's stupid, I know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #19103:
URL: https://github.com/apache/flink/pull/19103#discussion_r827797977
##########
File path: .github/workflows/docs.yml
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: "Build documentation"
+on:
+ workflow_dispatch:
+jobs:
+ build-documentation:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@master
+ - name: Set branch environment variable
+ run: |
+ currentBranch=$(git branch --show-current)
+
+ echo "flink_branch=${currentBranch}" >> ${GITHUB_ENV}
+
+ if [ "${currentBranch} = "master" ]; then
+ echo "flink_alias=release-1.16" >> ${GITHUB_ENV}
Review comment:
Couldn't we ignore this step for release-1.16? We currently also don't have https://nightlies.apache.org/flink/flink-docs-release-1.16/ as an alias for `master`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19103:
URL: https://github.com/apache/flink/pull/19103#issuecomment-1068269089
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54678bbe907d6f0dc70da226b0209e38fa06c59e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "54678bbe907d6f0dc70da226b0209e38fa06c59e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54678bbe907d6f0dc70da226b0209e38fa06c59e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #19103:
URL: https://github.com/apache/flink/pull/19103#issuecomment-1069090008
Did you (re)start from a clean git state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol edited a comment on pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #19103:
URL: https://github.com/apache/flink/pull/19103#issuecomment-1069190688
> to evaluate if it now would run quicker
@MartijnVisser In the long-term I want to bake dependencies directly into the docker image so we don't have to bother with CI caches. That should speed things up quite a bit (although the download on CI so far was reasonably fast during my experiments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #19103:
URL: https://github.com/apache/flink/pull/19103#issuecomment-1069190688
> to evaluate if it now would run quicker
@MartijnVisser In the long-term I want to bake dependencies directly into the docker image so we don't have to bother with CI caches. That should speed things up quite a bit (although the download on CI so far was reasonably fast during my experiments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19103:
URL: https://github.com/apache/flink/pull/19103#issuecomment-1069211692
> Did you (re)start from a clean git state?
Finally just finished. Had a clean git state, still failed with the same error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #19103:
URL: https://github.com/apache/flink/pull/19103#discussion_r827977965
##########
File path: .github/workflows/docs.yml
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: "Build documentation"
+on:
+ workflow_dispatch:
+jobs:
+ build-documentation:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@master
+ - name: Set branch environment variable
+ run: |
+ currentBranch=$(git branch --show-current)
+
+ echo "flink_branch=${currentBranch}" >> ${GITHUB_ENV}
+
+ if [ "${currentBranch} = "master" ]; then
+ echo "flink_alias=release-1.16" >> ${GITHUB_ENV}
Review comment:
> You mean like item 13 in the checklist of the `Prepare for the release` section? :)
Yes but then using Jira's task options, so you could also create an overview of the open tasks. But that could be overkill given that anyone who works on a release should read it properly and if you've done it once, you'll probably remember it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #19103:
URL: https://github.com/apache/flink/pull/19103#discussion_r827966093
##########
File path: .github/workflows/docs.yml
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: "Build documentation"
+on:
+ workflow_dispatch:
+jobs:
+ build-documentation:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@master
+ - name: Set branch environment variable
+ run: |
+ currentBranch=$(git branch --show-current)
+
+ echo "flink_branch=${currentBranch}" >> ${GITHUB_ENV}
+
+ if [ "${currentBranch} = "master" ]; then
+ echo "flink_alias=release-1.16" >> ${GITHUB_ENV}
Review comment:
Ah I also didn't find it, because I read "Major Release" and assumed it was applicable for a 1.x to 2.x release. Perhaps we should create some sort of checklist out of all these steps you can follow if you've completed all the steps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19103:
URL: https://github.com/apache/flink/pull/19103#discussion_r827921638
##########
File path: .github/workflows/docs.yml
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: "Build documentation"
+on:
+ workflow_dispatch:
+jobs:
+ build-documentation:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@master
+ - name: Set branch environment variable
+ run: |
+ currentBranch=$(git branch --show-current)
+
+ echo "flink_branch=${currentBranch}" >> ${GITHUB_ENV}
+
+ if [ "${currentBranch} = "master" ]; then
+ echo "flink_alias=release-1.16" >> ${GITHUB_ENV}
Review comment:
we don't have it only because you guys didn't update the buildbot setup when creating the 1.15 release branch :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19103:
URL: https://github.com/apache/flink/pull/19103#discussion_r827923267
##########
File path: .github/workflows/docs.yml
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: "Build documentation"
+on:
+ workflow_dispatch:
+jobs:
+ build-documentation:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@master
+ - name: Set branch environment variable
+ run: |
+ currentBranch=$(git branch --show-current)
+
+ echo "flink_branch=${currentBranch}" >> ${GITHUB_ENV}
+
+ if [ "${currentBranch} = "master" ]; then
+ echo "flink_alias=release-1.16" >> ${GITHUB_ENV}
Review comment:
Ah there it is; `Create a release branch#Major Release`:
> After pushing the new major release branch, as the last step you should also update the documentation build bot to also build the documentation for the new release branch. Check [Managing Documentation](https://cwiki.apache.org/confluence/display/FLINK/Managing+Documentation) on details on how to do that. You may also want to manually trigger a build to make the changes visible as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19103:
URL: https://github.com/apache/flink/pull/19103#issuecomment-1069042947
Ah, it actually completed. Just took a long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19103:
URL: https://github.com/apache/flink/pull/19103#issuecomment-1069088689
When running the script for the same time (to evaluate if it now would run quicker), I got an error during the Python step:
```
============installing environment============
installing wget...
install wget... [SUCCESS]
installing miniconda...
download miniconda...
download miniconda... [SUCCESS]
installing conda...
WARNING conda.core.envs_manager:register_env(46): Unable to register environment. Path not writable or missing.
environment location: /root/flink/flink-python/dev/.conda
registry file: /root/.conda/environments.txt
ERROR conda.core.link:_execute(637): An error occurred while installing package 'defaults::ncurses-6.1-he6710b0_1'.
CondaError: Cannot link a source that does not exist. /root/flink/flink-python/dev/.conda/pkgs/ncurses-6.1-he6710b0_1/share/terminfo/e/eterm-color
Running `conda clean --packages` may resolve your problem.
Attempting to roll back.
CondaError: Cannot link a source that does not exist. /root/flink/flink-python/dev/.conda/pkgs/ncurses-6.1-he6710b0_1/share/terminfo/e/eterm-color
Running `conda clean --packages` may resolve your problem.
()
install miniconda failed
mv: cannot stat 'flink-python/docs/_build/html': No such file or directory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19103:
URL: https://github.com/apache/flink/pull/19103#discussion_r827922680
##########
File path: .github/workflows/docs.yml
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: "Build documentation"
+on:
+ workflow_dispatch:
+jobs:
+ build-documentation:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@master
+ - name: Set branch environment variable
+ run: |
+ currentBranch=$(git branch --show-current)
+
+ echo "flink_branch=${currentBranch}" >> ${GITHUB_ENV}
+
+ if [ "${currentBranch} = "master" ]; then
+ echo "flink_alias=release-1.16" >> ${GITHUB_ENV}
Review comment:
IIRC we always did that when creating the release branch.
although admittedly I can't find it in the release guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #19103:
URL: https://github.com/apache/flink/pull/19103#issuecomment-1069231730
@MartijnVisser On CI it ran in ~20 minutes. https://github.com/apache/flink/actions/runs/1987354118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19103:
URL: https://github.com/apache/flink/pull/19103#discussion_r827970480
##########
File path: .github/workflows/docs.yml
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: "Build documentation"
+on:
+ workflow_dispatch:
+jobs:
+ build-documentation:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@master
+ - name: Set branch environment variable
+ run: |
+ currentBranch=$(git branch --show-current)
+
+ echo "flink_branch=${currentBranch}" >> ${GITHUB_ENV}
+
+ if [ "${currentBranch} = "master" ]; then
+ echo "flink_alias=release-1.16" >> ${GITHUB_ENV}
Review comment:
You mean like item 13 in the `Prepare for the release` section? :)
> (major only) The documentation for the new major release is visible under https://nightlies.apache.org/flink/flink-docs-release-$SHORT_RELEASE_VERSION (after at least one doc build finishes).
Note that in terms of Flink, major refers to 1.X.0, while miner are 1.Y.X. We don't have a term for 2.x. It's stupid, I know.
##########
File path: .github/workflows/docs.yml
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: "Build documentation"
+on:
+ workflow_dispatch:
+jobs:
+ build-documentation:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@master
+ - name: Set branch environment variable
+ run: |
+ currentBranch=$(git branch --show-current)
+
+ echo "flink_branch=${currentBranch}" >> ${GITHUB_ENV}
+
+ if [ "${currentBranch} = "master" ]; then
+ echo "flink_alias=release-1.16" >> ${GITHUB_ENV}
Review comment:
You mean like item 13 in the checklist of the `Prepare for the release` section? :)
> (major only) The documentation for the new major release is visible under https://nightlies.apache.org/flink/flink-docs-release-$SHORT_RELEASE_VERSION (after at least one doc build finishes).
Note that in terms of Flink, major refers to 1.X.0, while miner are 1.Y.X. We don't have a term for 2.x. It's stupid, I know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #19103:
URL: https://github.com/apache/flink/pull/19103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19103: [FLINK-26658][docs] Migrate documentation build to Github Actions
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19103:
URL: https://github.com/apache/flink/pull/19103#issuecomment-1069194667
> > to evaluate if it now would run quicker
>
> @MartijnVisser In the long-term I want to bake dependencies directly into the docker image so we don't have to bother with CI caches. That should speed things up quite a bit (although the download on CI so far was reasonably fast during my experiments).
I'm really baffled why it takes so long locally for me. I started a run 2 hours ago which hasn't completed yet. But either way I guess we should just see how it works on GHA first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org