RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util J avaGeneratorTool.java

[Larry Isaacs <La...@sas.com>]

Tomcat 3.3 doesn't throw an exception but the coe in
3.3 doesn't accomplish what was intended.  See:

<http://nagoya.betaversion.org/bugzilla/show_bug.cgi?id=5365>

Bugs in code like this often take more than one try to
fix.  Hopefully my commit completes the fix. :-)

Larry

> -----Original Message-----
> From: Renato [mailto:webmaster@cienciapura.com.br]
> Sent: Wednesday, December 19, 2001 6:21 AM
> To: Tomcat Developers List
> Subject: RE: cvs commit: 
> jakarta-tomcat/src/share/org/apache/tomcat/util
> J avaGeneratorTool.java
> 
> 
> Is Tomcat 3.3 affected by this ?
> 
> 
> On Wed, 19 Dec 2001 08:10:52 -0500, Larry Isaacs 
> <La...@sas.com> 
> escreveu :
> 
> > I can't get code involving index and length right without
> > a lot of trial and error.  Fortunately the internal test
> > revealed this one.
> > 
> > Larry
> > 
> > > -----Original Message-----
> > > From: Bill Barker [mailto:wbarker@wilshire.com]
> > > Sent: Wednesday, December 19, 2001 1:09 AM
> > > To: Tomcat Developers List
> > > Subject: Re: cvs commit: 
> > > jakarta-tomcat/src/share/org/apache/tomcat/util
> > > JavaGeneratorTool.java
> > > 
> > > 
> > > Oh, well, I guess I had to screw up eventually :-(
> > > 
> > > Thanks for cleaning up my mess.
> > > ----- Original Message -----
> > > From: <la...@apache.org>
> > > To: <ja...@apache.org>
> > > Sent: Tuesday, December 18, 2001 6:39 PM
> > > Subject: cvs commit: 
> jakarta-tomcat/src/share/org/apache/tomcat/util
> > > JavaGeneratorTool.java
> > > 
> > > 
> > > > larryi      01/12/18 18:39:39
> > > >
> > > >   Modified:    src/share/org/apache/tomcat/util 
> > > JavaGeneratorTool.java
> > > >   Log:
> > > >   Fix IndexOutOfBoundsException
> > > >
> > > >   Revision  Changes    Path
> > > >   1.5       +1 -1
> > > 
> jakarta-tomcat/src/share/org/apache/tomcat/util/JavaGeneratorTool.java
> > > >
> > > >   Index: JavaGeneratorTool.java
> > > >   
> > > 
> ===================================================================
> > > >   RCS file:
> > > /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/Java
> > > GeneratorTool.
> > > java,v
> > > >   retrieving revision 1.4
> > > >   retrieving revision 1.5
> > > >   diff -u -r1.4 -r1.5
> > > >   --- JavaGeneratorTool.java 2001/12/14 03:55:11 1.4
> > > >   +++ JavaGeneratorTool.java 2001/12/19 02:39:39 1.5
> > > >   @@ -78,7 +78,7 @@
> > > >        continue;
> > > >    }
> > > >
> > > >   - if( (s.length()>=endIdx) && s.charAt( endIdx ) != '/' ) {
> > > >   + if( (s.length()>endIdx) && s.charAt( endIdx ) != '/' ) {
> > > >        index = s.indexOf(keywords[i],index+3);
> > > >        continue;
> > > >    }
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > To unsubscribe, e-mail:
> > > <ma...@jakarta.apache.org>
> > > > For additional commands, e-mail:
> > > <ma...@jakarta.apache.org>
> > > >
> > > 
> > > 
> > > --
> > > To unsubscribe, e-mail:   
> > > <ma...@jakarta.apache.org>
> > > For additional commands, e-mail: 
> > > <ma...@jakarta.apache.org>
> > > 
> > 
> > --
> > To unsubscribe, e-mail:   <mailto:tomcat-dev-
> unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail: <mailto:tomcat-dev-
> help@jakarta.apache.org>
> > 
> > 
> > 
> > 
> 
> --
> To unsubscribe, e-mail:   
> <ma...@jakarta.apache.org>
> For additional commands, e-mail: 
> <ma...@jakarta.apache.org>
> 

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>