You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/25 13:03:54 UTC
[GitHub] [incubator-doris] gengjun-git opened a new pull request #4450: Fix mysql return bug
gengjun-git opened a new pull request #4450:
URL: https://github.com/apache/incubator-doris/pull/4450
For issue #4449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] gengjun-git commented on a change in pull request #4450: Fix mysql return bug
Posted by GitBox <gi...@apache.org>.
gengjun-git commented on a change in pull request #4450:
URL: https://github.com/apache/incubator-doris/pull/4450#discussion_r476978240
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
##########
@@ -622,13 +622,15 @@ private void handleQueryStmt() throws Exception {
RowBatch batch;
MysqlChannel channel = context.getMysqlChannel();
boolean isOutfileQuery = queryStmt.hasOutFileClause();
- if (!isOutfileQuery) {
- sendFields(queryStmt.getColLabels(), queryStmt.getResultExprs());
- }
+ boolean isSendFields = false;
Review comment:
Yes, fields has been sent, but query may fail because of timeout. In this case, client will get a fields packet, and error packet, but some language mysql driver cannot recognize the error, and returns a success and no rows result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4450: Fix mysql return bug
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4450:
URL: https://github.com/apache/incubator-doris/pull/4450#discussion_r476471738
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
##########
@@ -622,13 +622,15 @@ private void handleQueryStmt() throws Exception {
RowBatch batch;
MysqlChannel channel = context.getMysqlChannel();
boolean isOutfileQuery = queryStmt.hasOutFileClause();
- if (!isOutfileQuery) {
- sendFields(queryStmt.getColLabels(), queryStmt.getResultExprs());
- }
+ boolean isSendFields = false;
Review comment:
So the reason is that the `fields` has been sent but no data is sent following?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4450: Fix mysql return bug
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4450:
URL: https://github.com/apache/incubator-doris/pull/4450#issuecomment-680040272
Hi @gengjun-git , you can write "Fix #4449", so that the related issue will be closed automatically when this PR is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4450: Fix mysql return bug
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4450:
URL: https://github.com/apache/incubator-doris/pull/4450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org