You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/23 11:47:39 UTC

[GitHub] [flink] Xeli opened a new pull request #12301: [FLINK-16572] [pubsub,e2e] Add check to see if adding a timeout to th…

Xeli opened a new pull request #12301:
URL: https://github.com/apache/flink/pull/12301


   This MR adds some extra logging to pubsub e2e test.
   
   Because it's quite hard to reproduce locally we want to try and see what these extra logs tells us when it naturally happens again on azure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12301: [FLINK-16572] [pubsub,e2e] Add check to see if adding a timeout to th…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12301:
URL: https://github.com/apache/flink/pull/12301#issuecomment-633042244


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3b8f38cc685f05413dde8016aa1714ac1742e20",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2069",
       "triggerID" : "a3b8f38cc685f05413dde8016aa1714ac1742e20",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a3b8f38cc685f05413dde8016aa1714ac1742e20 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2069) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #12301: [FLINK-16572] [pubsub,e2e] Add check to see if adding a timeout to th…

Posted by GitBox <gi...@apache.org>.

rmetzger commented on pull request #12301:
URL: https://github.com/apache/flink/pull/12301#issuecomment-633399279


   Thanks a lot! Merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12301: [FLINK-16572] [pubsub,e2e] Add check to see if adding a timeout to th…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12301:
URL: https://github.com/apache/flink/pull/12301#issuecomment-633042244


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3b8f38cc685f05413dde8016aa1714ac1742e20",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2069",
       "triggerID" : "a3b8f38cc685f05413dde8016aa1714ac1742e20",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a3b8f38cc685f05413dde8016aa1714ac1742e20 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2069) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12301: [FLINK-16572] [pubsub,e2e] Add check to see if adding a timeout to th…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12301:
URL: https://github.com/apache/flink/pull/12301#issuecomment-633035319

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit a3b8f38cc685f05413dde8016aa1714ac1742e20 (Sat May 23 11:49:20 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12301: [FLINK-16572] [pubsub,e2e] Add check to see if adding a timeout to th…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12301:
URL: https://github.com/apache/flink/pull/12301#issuecomment-633042244


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3b8f38cc685f05413dde8016aa1714ac1742e20",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a3b8f38cc685f05413dde8016aa1714ac1742e20",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a3b8f38cc685f05413dde8016aa1714ac1742e20 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger merged pull request #12301: [FLINK-16572] [pubsub,e2e] Add check to see if adding a timeout to th…

Posted by GitBox <gi...@apache.org>.

rmetzger merged pull request #12301:
URL: https://github.com/apache/flink/pull/12301


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #12301: [FLINK-16572] [pubsub,e2e] Add check to see if adding a timeout to th…

Posted by GitBox <gi...@apache.org>.

rmetzger commented on pull request #12301:
URL: https://github.com/apache/flink/pull/12301#issuecomment-633404724


   Yes, that's my fault.
   The GitHub "merge" button hat an error and then produced this merge commit when I clicked "try again" :(
   
   Merge commits are actually disabled for this repository. I guess this is a Bug in GitHub.
   
   ![image](https://user-images.githubusercontent.com/89049/82785487-f275a000-9e62-11ea-83c7-f9139446d8e8.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] KarmaGYZ commented on pull request #12301: [FLINK-16572] [pubsub,e2e] Add check to see if adding a timeout to th…

Posted by GitBox <gi...@apache.org>.

KarmaGYZ commented on pull request #12301:
URL: https://github.com/apache/flink/pull/12301#issuecomment-633401619


   It seems something went wrong with the commit message in master branch:
   `Merge pull request #12301 from Xeli/FLINK-16572-logs`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org