You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/25 11:17:40 UTC

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1005: IGNITE-17430 Sql. Provide commands and handlers for index related operations.

AMashenkov commented on code in PR #1005:
URL: https://github.com/apache/ignite-3/pull/1005#discussion_r954837502


##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##########
@@ -225,13 +256,32 @@ public CompletableFuture<Index<?>> createIndexAsync(
      *
      * @param schemaName A name of the schema the index belong to.
      * @param indexName A name of the index to drop.
+     * @param failIfNotExist Flag, which force failure, when {@code trues} if index doen't not exists.
+     * @return {@code True} if index was removed, {@code false} otherwise.
+     * @throws IndexNotFoundException If index doesn't exist and {@code failIfNotExist} param was {@code true}.
+     */
+    public boolean dropIndex(

Review Comment:
   DdlCommanHandler uses synchronous methods for alter table operations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org