You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/12 10:21:45 UTC
[GitHub] [incubator-seatunnel] ruanwenjun opened a new pull request, #1688: [Feature][Plugin] Add Plugin Flink Sink Clickhouse
ruanwenjun opened a new pull request, #1688:
URL: https://github.com/apache/incubator-seatunnel/pull/1688
## Purpose of this pull request
close #1063
The main changes of this PR
1. Add flink-clickhouse connector, support batch sink into clickhouse.
2. Add flink-clickhouse e2e test.
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/development/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1688: [Feature][Plugin] Add Plugin Flink Sink Clickhouse
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1688:
URL: https://github.com/apache/incubator-seatunnel/pull/1688#issuecomment-1096690811
@CalvinKirs @BenJFan Please take a look, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie commented on pull request #1688: [Feature][Plugin] Add Plugin Flink Sink Clickhouse
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #1688:
URL: https://github.com/apache/incubator-seatunnel/pull/1688#issuecomment-1098636247
> > @ruanwenjun hi, wenjun, The document may need to be adjusted, adjusted to `tabs` , you can refer to the writing method of other documents, thanks
>
> Hi, chunfu. The parameters of Clickhouse are the same in flink and spark engine. So I think we don't need to add a`tabs` here.
Correct, when the parameter are same in both flink and spark, we should not and `<tab>` anymore. We should ask the new connector to keep the same param as exists one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1688: [Feature][Plugin] Add Plugin Flink Sink Clickhouse
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on PR #1688:
URL: https://github.com/apache/incubator-seatunnel/pull/1688#issuecomment-1097525731
@ruanwenjun hi, wenjun, The document may need to be adjusted, adjusted to `tabs` , you can refer to the writing method of other documents, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1688: [Feature][Plugin] Add Plugin Flink Sink Clickhouse
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #1688:
URL: https://github.com/apache/incubator-seatunnel/pull/1688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1688: [Feature][Plugin] Add Plugin Flink Sink Clickhouse
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on PR #1688:
URL: https://github.com/apache/incubator-seatunnel/pull/1688#issuecomment-1098646380
> > > @ruanwenjun hi, wenjun, The document may need to be adjusted, adjusted to `tabs` , you can refer to the writing method of other documents, thanks
> >
> >
> > Hi, chunfu. The parameters of Clickhouse are the same in flink and spark engine. So I think we don't need to add a`tabs` here.
>
> Correct, when the parameter are same in both flink and spark, we should not and `<tab>` anymore. We should ask the new connector to keep the same param as exists one
Agree with you, @zhongjiajie @ruanwenjun , Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1688: [Feature][Plugin] Add Plugin Flink Sink Clickhouse
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1688:
URL: https://github.com/apache/incubator-seatunnel/pull/1688#issuecomment-1097599223
> @ruanwenjun hi, wenjun, The document may need to be adjusted, adjusted to `tabs` , you can refer to the writing method of other documents, thanks
Hi, chunfu. The parameters of Clickhouse are the same in flink and spark engine. So I think we don't need to add a`tabs` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1688: [Feature][Plugin] Add Plugin Flink Sink Clickhouse
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on PR #1688:
URL: https://github.com/apache/incubator-seatunnel/pull/1688#issuecomment-1097779266
> > @ruanwenjun hi, wenjun, The document may need to be adjusted, adjusted to `tabs` , you can refer to the writing method of other documents, thanks
>
> Hi, chunfu. The parameters of Clickhouse are the same in flink and spark engine. So I think we don't need to add a`tabs` here.
@ruanwenjun Please ignore me and listen to @zhongjiajie Jiajie's advice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org