[GitHub] [commons-lang] verhas commented on a change in pull request #448: Lang 1482

[GitBox <gi...@apache.org>]

verhas commented on a change in pull request #448: Lang 1482
URL: https://github.com/apache/commons-lang/pull/448#discussion_r343465751
 
 

 ##########
 File path: src/test/java/org/apache/commons/lang3/FunctionsTest.java
 ##########
 @@ -414,8 +412,8 @@ public void testAsPredicate() {
         assertNotNull(cause);
         assertTrue(cause instanceof SomeException);
         assertEquals("Odd Invocation: 1", cause.getMessage());
+        // assert that it does not throw exception
         final boolean instance = predicate.test(null);
 
 Review comment:
   `assertNotNull()` makes no sense on primitive

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services