You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/11/04 18:36:14 UTC
[GitHub] [solr] joel-bernstein opened a new pull request, #1162: Fix StreamDecoratorTest.testParallelTerminatingDaemonUpdateStream Con…
joel-bernstein opened a new pull request, #1162:
URL: https://github.com/apache/solr/pull/1162
…currentModificationException
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1162: SOLR-16510: Fix StreamDecoratorTest.testParallelTerminatingDaemonUpdateStream Con…
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1162:
URL: https://github.com/apache/solr/pull/1162#issuecomment-1304133481
I'll check those other streams, I believe they are ok as written though as I don't think there is an iterator involved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1162: SOLR-16510: Fix StreamDecoratorTest.testParallelTerminatingDaemonUpdateStream Con…
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1162:
URL: https://github.com/apache/solr/pull/1162#issuecomment-1304114264
Change makes sense - does it make sense to check these other cases potentially too?
```
git grep -F Collections.synchronizedMap -- solr/solrj-streaming/
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java: this.eofTuples = Collections.synchronizedMap(new HashMap<>());
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/DeepRandomStream.java: this.eofTuples = Collections.synchronizedMap(new HashMap<>());
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/TopicStream.java: this.eofTuples = Collections.synchronizedMap(new HashMap<>());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein merged pull request #1162: SOLR-16510: Fix StreamDecoratorTest.testParallelTerminatingDaemonUpdateStream Con…
Posted by GitBox <gi...@apache.org>.
joel-bernstein merged PR #1162:
URL: https://github.com/apache/solr/pull/1162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org