You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/04 13:30:41 UTC

[GitHub] [flink] ferenc-csaky commented on a diff in pull request #20542: [FLINK-28910][Connectors/hbase]Fix potential data deletion while updating HBase rows

ferenc-csaky commented on code in PR #20542:
URL: https://github.com/apache/flink/pull/20542#discussion_r1014021957


##########
flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/HBaseSinkFunction.java:
##########
@@ -76,6 +80,7 @@
     private transient ScheduledExecutorService executor;
     private transient ScheduledFuture scheduledFuture;
     private transient AtomicLong numPendingRequests;
+    private Map<ByteBuffer, Mutation> mutationMap = new HashMap<>();

Review Comment:
   This field could be `final` as well. Can we move it under `mutationConverter` and init it inside the ctor to be consistent with the field initialization?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org