[GitHub] [spark] beliefer commented on a diff in pull request #36934: [SPARK-39537][SQL] Ensure that the expressions order returned by `InferFiltersFromConstraints`

[GitBox <gi...@apache.org>]

beliefer commented on code in PR #36934:
URL: https://github.com/apache/spark/pull/36934#discussion_r902196418


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1272,8 +1272,11 @@ object InferFiltersFromConstraints extends Rule[LogicalPlan]
   private def inferFilters(plan: LogicalPlan): LogicalPlan = plan.transformWithPruning(
     _.containsAnyPattern(FILTER, JOIN)) {
     case filter @ Filter(condition, child) =>
-      val newFilters = filter.constraints --

Review Comment:
   It seems https://github.com/apache/spark/pull/36925 fixed this issue ? @LuciferYang 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org