You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:20:24 UTC
[GitHub] [airflow] uranusjr opened a new pull request #16393: Handle missing/null serialized DAG dependencies
uranusjr opened a new pull request #16393:
URL: https://github.com/apache/airflow/pull/16393
When a serialized DAG is missing a `dag_dependencies` field (possible when upgrading), PostgreSQL would return NULL when accessing the field with a JSON function. This value would fail subsequent code, so we need some logic to handle it.
I took the oppertunity to rewrite the entire `get_dag_dependencies` function to use iterators. This should slightly improve performance.
Fix #16356.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #16393: Handle missing/null serialized DAG dependencies
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #16393:
URL: https://github.com/apache/airflow/pull/16393#issuecomment-861769408
> Rebased and now the linter is passing. There are a couple of failures in Helm Chart tests:
>
> ```
> FAILED chart/tests/test_ingress_flower.py::IngressFlowerTest::test_should_allow_more_than_one_annotation
> FAILED chart/tests/test_limit_ranges.py::LimitRangesTest::test_limit_ranges_template
> ```
>
> I have no idea what went wrong; seems like flaky network issues?
Yup, ran those tests locally, all green.
```
============================================================================================== 370 passed in 374.22s (0:06:14) ===============================================================================================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16393: Handle missing/null serialized DAG dependencies
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16393:
URL: https://github.com/apache/airflow/pull/16393#issuecomment-861349422
Rebased and now the linter is passing. There are a couple of failures in Helm Chart tests:
```
FAILED chart/tests/test_ingress_flower.py::IngressFlowerTest::test_should_allow_more_than_one_annotation
FAILED chart/tests/test_limit_ranges.py::LimitRangesTest::test_limit_ranges_template
```
I have no idea what went wrong; seems like flaky network issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16393: Handle missing/null serialized DAG dependencies
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16393:
URL: https://github.com/apache/airflow/pull/16393#issuecomment-859659527
Test added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16393: Handle missing/null serialized DAG dependencies
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16393:
URL: https://github.com/apache/airflow/pull/16393#issuecomment-860125141
tests failing :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #16393: Handle missing/null serialized DAG dependencies
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #16393:
URL: https://github.com/apache/airflow/pull/16393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #16393: Handle missing/null serialized DAG dependencies
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #16393:
URL: https://github.com/apache/airflow/pull/16393#issuecomment-861020075
@uranusjr Pylint failure:
```
************* Module tests.decorators.test_python
tests/decorators/test_python.py:458:62: E1101: Instance of 'str' has no 'task_id' member (no-member)
```
Probably rebasing on Master might fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16393: Handle missing/null serialized DAG dependencies
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16393:
URL: https://github.com/apache/airflow/pull/16393#issuecomment-859654287
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org