You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "risdenk (via GitHub)" <gi...@apache.org> on 2023/02/03 17:36:35 UTC
[GitHub] [solr] risdenk opened a new pull request, #1330: SOLR-15955: Jetty 10.x upgrade notes
risdenk opened a new pull request, #1330:
URL: https://github.com/apache/solr/pull/1330
https://issues.apache.org/jira/browse/SOLR-15955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a diff in pull request #1330: SOLR-15955: Jetty 10.x upgrade notes
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #1330:
URL: https://github.com/apache/solr/pull/1330#discussion_r1096112932
##########
solr/CHANGES.txt:
##########
@@ -51,6 +51,8 @@ New Features
* SOLR-16596: Learning To Rank - Added support for null feature values in multiple additive trees models (Anna Ruggero via Alessandro Benedetti)
+* SOLR-15955: Upgrade to Jetty 10.x (Mark Miller, Kevin Risden)
+
Review Comment:
Typically goes in Other Changes. Could be justified in some other categories if we expect an appreciable difference.
Obviously this is a big dependency upgrade so it should be called out when we do the release notes, maybe mentioning some benefits if you know of any in particular that matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1330: SOLR-15955: Jetty 10.x upgrade notes
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on code in PR #1330:
URL: https://github.com/apache/solr/pull/1330#discussion_r1096071702
##########
solr/CHANGES.txt:
##########
@@ -51,6 +51,8 @@ New Features
* SOLR-16596: Learning To Rank - Added support for null feature values in multiple additive trees models (Anna Ruggero via Alessandro Benedetti)
+* SOLR-15955: Upgrade to Jetty 10.x (Mark Miller, Kevin Risden)
+
Review Comment:
Not sure that under `"New Feature"` makes sense, but figured it was good to call out up top.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1330: SOLR-15955: Jetty 10.x upgrade notes
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on code in PR #1330:
URL: https://github.com/apache/solr/pull/1330#discussion_r1097506015
##########
solr/CHANGES.txt:
##########
@@ -51,6 +51,8 @@ New Features
* SOLR-16596: Learning To Rank - Added support for null feature values in multiple additive trees models (Anna Ruggero via Alessandro Benedetti)
+* SOLR-15955: Upgrade to Jetty 10.x (Mark Miller, Kevin Risden)
+
Review Comment:
moved to other changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a diff in pull request #1330: SOLR-15955: Jetty 10.x upgrade notes
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #1330:
URL: https://github.com/apache/solr/pull/1330#discussion_r1096094877
##########
solr/CHANGES.txt:
##########
@@ -51,6 +51,8 @@ New Features
* SOLR-16596: Learning To Rank - Added support for null feature values in multiple additive trees models (Anna Ruggero via Alessandro Benedetti)
+* SOLR-15955: Upgrade to Jetty 10.x (Mark Miller, Kevin Risden)
+
Review Comment:
Definitely not "New Feature" for bumping up a dependency unless somehow the user gets some new ability here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1330: SOLR-15955: Jetty 10.x upgrade notes
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on code in PR #1330:
URL: https://github.com/apache/solr/pull/1330#discussion_r1096097098
##########
solr/CHANGES.txt:
##########
@@ -51,6 +51,8 @@ New Features
* SOLR-16596: Learning To Rank - Added support for null feature values in multiple additive trees models (Anna Ruggero via Alessandro Benedetti)
+* SOLR-15955: Upgrade to Jetty 10.x (Mark Miller, Kevin Risden)
+
Review Comment:
Thats fair - the only existing place that made rough sense was "Other Changes" or "Build" based on the existing categories being:
* New Features
* Improvements
* Optimizations
* Bug Fixes
* Build
* Other Changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1330: SOLR-15955: Jetty 10.x upgrade notes
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk merged PR #1330:
URL: https://github.com/apache/solr/pull/1330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org