You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "masayag (via GitHub)" <gi...@apache.org> on 2024/02/26 12:02:28 UTC
[I] Provide a method to set labels to the k8s resources of the workflow [incubator-kie-kogito-serverless-operator]
masayag opened a new issue, #410:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/issues/410
### Description
We'd like a way that enables us to label K8s resources related to the Sonataflow CR. E.g have the same labels appear in k8s deployment, pod, service, route and so.
Today, only default labels are applied to those resources (`app=workflow-name`, `sonataflow.org/workflow-app=`, `sonataflow.org/service=`)
A private case of it is Backstage plugins that interact with K8s cluster (ci, gitops and others).
In backstage, to view workflow resources related to a component under the CI (tekton) and K8s tabs, a specific label should be set on the pods (e.g. `backstage.io/kubernetes-id=application-onboarding`).
By enabling the label, the user can view pipelines related to the workflow as in the attached image:
For the CI:
And for K8s:
### Implementation ideas
* Propagate Sonataflow CR labels to the deployment.
* Extend the Sonataflow CR API to support it.
I'm in favor of the first option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Provide a method to set labels to the k8s resources of the workflow [incubator-kie-kogito-serverless-operator]
Posted by "masayag (via GitHub)" <gi...@apache.org>.
masayag commented on issue #410:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/issues/410#issuecomment-1965237613
> I think we can propagate the labels from the `SonataFlow` CR to the resources. So any custom labels added there by users would also be added to the resources. Is this a reasonable approach for you?
That's sounds great :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Provide a method to set labels to the k8s resources of the workflow [incubator-kie-kogito-serverless-operator]
Posted by "masayag (via GitHub)" <gi...@apache.org>.
masayag commented on issue #410:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/issues/410#issuecomment-1963988753
@ricardozanini can you see if this is acceptable? we can work on a PR for it if so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Provide a method to set labels to the k8s resources of the workflow [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on issue #410:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/issues/410#issuecomment-1966460706
@masayag go ahead and send a PR! :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Provide a method to set labels to the k8s resources of the workflow [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on issue #410:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/issues/410#issuecomment-1965221082
I think we can propagate the labels from the `SonataFlow` CR to the resources. So any custom labels added there by users would also be added to the resources. Is this a reasonable approach for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Provide a method to set labels to the k8s resources of the workflow [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini closed issue #410: Provide a method to set labels to the k8s resources of the workflow
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/issues/410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org