You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/24 10:44:09 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7367: Add Thread and ClassLoader Metrics for the self-observability

wu-sheng commented on a change in pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#discussion_r675983013



##########
File path: test/e2e/e2e-data/src/main/java/org/apache/skywalking/e2e/metrics/MetricsQuery.java
##########
@@ -137,13 +137,21 @@
     public static String METER_INSTANCE_METRICS_FIRST_AGGREGATION = "meter_oap_instance_metrics_first_aggregation";
     public static String METER_INSTANCE_PERSISTENCE_PREPARE_COUNT = "meter_oap_instance_persistence_prepare_count";
     public static String METER_INSTANCE_PERSISTENCE_EXECUTE_COUNT = "meter_oap_instance_persistence_execute_count";
+    public static String METER_INSTANCE_JVM_THREAD_LIVE_COUNT = "meter_oap_instance_jvm_thread_live_count";
+    public static String METER_INSTANCE_JVM_THREAD_RUNNABLE_STATE_THREAD_COUNT = "meter_oap_instance_jvm_thread_runnable_state_thread_count";
+    public static String METER_INSTANCE_JVM_CLASS_LOADED_CLASS_COUNT = "meter_oap_instance_jvm_class_loaded_class_count";
+    public static String METER_INSTANCE_JVM_CLASS_TOTAL_LOADED_CLASS_COUNT = "meter_oap_instance_jvm_class_total_loaded_class_count";
 
     public static String[] ALL_SO11Y_LINER_METRICS = {
         METER_INSTANCE_CPU_PERCENTAGE,
         METER_INSTANCE_JVM_MEMORY_BYTES_USED,
         METER_INSTANCE_METRICS_FIRST_AGGREGATION,
         METER_INSTANCE_PERSISTENCE_PREPARE_COUNT,
-        METER_INSTANCE_PERSISTENCE_EXECUTE_COUNT 
+        METER_INSTANCE_PERSISTENCE_EXECUTE_COUNT,
+        METER_INSTANCE_JVM_THREAD_LIVE_COUNT,

Review comment:
       Does the live thread metric really have values? I can't see that from your screenshots.

##########
File path: test/e2e/e2e-data/src/main/java/org/apache/skywalking/e2e/metrics/MetricsQuery.java
##########
@@ -137,13 +137,21 @@
     public static String METER_INSTANCE_METRICS_FIRST_AGGREGATION = "meter_oap_instance_metrics_first_aggregation";
     public static String METER_INSTANCE_PERSISTENCE_PREPARE_COUNT = "meter_oap_instance_persistence_prepare_count";
     public static String METER_INSTANCE_PERSISTENCE_EXECUTE_COUNT = "meter_oap_instance_persistence_execute_count";
+    public static String METER_INSTANCE_JVM_THREAD_LIVE_COUNT = "meter_oap_instance_jvm_thread_live_count";
+    public static String METER_INSTANCE_JVM_THREAD_RUNNABLE_STATE_THREAD_COUNT = "meter_oap_instance_jvm_thread_runnable_state_thread_count";
+    public static String METER_INSTANCE_JVM_CLASS_LOADED_CLASS_COUNT = "meter_oap_instance_jvm_class_loaded_class_count";
+    public static String METER_INSTANCE_JVM_CLASS_TOTAL_LOADED_CLASS_COUNT = "meter_oap_instance_jvm_class_total_loaded_class_count";
 
     public static String[] ALL_SO11Y_LINER_METRICS = {
         METER_INSTANCE_CPU_PERCENTAGE,
         METER_INSTANCE_JVM_MEMORY_BYTES_USED,
         METER_INSTANCE_METRICS_FIRST_AGGREGATION,
         METER_INSTANCE_PERSISTENCE_PREPARE_COUNT,
-        METER_INSTANCE_PERSISTENCE_EXECUTE_COUNT 
+        METER_INSTANCE_PERSISTENCE_EXECUTE_COUNT,
+        METER_INSTANCE_JVM_THREAD_LIVE_COUNT,

Review comment:
       Or other metrics are always having no-zero values? E2e is checking the values of metrics.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org