You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/01/08 12:03:18 UTC
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2450: add da1469x SPI bus driver
apache-mynewt-bot removed a comment on pull request #2450:
URL: https://github.com/apache/mynewt-core/pull/2450#issuecomment-756717977
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/bus/drivers/spi_da1469x/src/spi_da1469x.c
<details>
```diff
@@ -34,15 +34,15 @@
#if MYNEWT_VAL(SPI_DA1469X_STAT)
STATS_SECT_START(spi_da1469x_stats_section)
- STATS_SECT_ENTRY(read_bytes)
- STATS_SECT_ENTRY(written_bytes)
- STATS_SECT_ENTRY(dma_transferred_bytes)
+STATS_SECT_ENTRY(read_bytes)
+STATS_SECT_ENTRY(written_bytes)
+STATS_SECT_ENTRY(dma_transferred_bytes)
STATS_SECT_END
STATS_NAME_START(spi_da1469x_stats_section)
- STATS_NAME(spi_da1469x_stats_section, read_bytes)
- STATS_NAME(spi_da1469x_stats_section, written_bytes)
- STATS_NAME(spi_da1469x_stats_section, dma_transferred_bytes)
+STATS_NAME(spi_da1469x_stats_section, read_bytes)
+STATS_NAME(spi_da1469x_stats_section, written_bytes)
+STATS_NAME(spi_da1469x_stats_section, dma_transferred_bytes)
STATS_NAME_END(spi_da1469x_stats_section)
#endif
@@ -138,13 +138,13 @@
/* Number of bytes read from input FIFO */
uint16_t rlen;
- uint8_t nostop:1;
+ uint8_t nostop : 1;
/* Current transfer is for write */
- uint8_t write:1;
+ uint8_t write : 1;
/* DMA is used for current transfer */
- uint8_t dma:1;
+ uint8_t dma : 1;
/* Transfer started */
- uint8_t started:1;
+ uint8_t started : 1;
};
struct spi_da1469x_driver_data {
@@ -163,7 +163,8 @@
static struct spi_da1469x_driver_data spi_dev_data_0;
static struct spi_da1469x_driver_data spi_dev_data_1;
-static inline struct spi_da1469x_driver_data *driver_data(struct bus_spi_dev *dev)
+static inline struct spi_da1469x_driver_data *
+driver_data(struct bus_spi_dev *dev)
{
if (MYNEWT_VAL(SPI_0_MASTER) && dev->cfg.spi_num == 0) {
return &spi_dev_data_0;
@@ -633,7 +634,7 @@
stats_name);
#endif
- rc = bus_dev_init_func(odev, (void*)&bus_spi_da1469x_ops);
+ rc = bus_dev_init_func(odev, (void *)&bus_spi_da1469x_ops);
assert(rc == 0);
return 0;
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org