You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "raiden00pl (via GitHub)" <gi...@apache.org> on 2024/04/27 07:21:50 UTC
[PR] boards/arm/stm32/common/src/stm32_bh1750.c: fix include [nuttx]
raiden00pl opened a new pull request, #12241:
URL: https://github.com/apache/nuttx/pull/12241
## Summary
boards/arm/stm32/common/src/stm32_bh1750.c: fix include
should include i2c interface, not spi
## Impact
## Testing
ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/arm/stm32/common/src/stm32_bh1750.c: fix include [nuttx]
Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on PR #12241:
URL: https://github.com/apache/nuttx/pull/12241#issuecomment-2080738087
@raiden00p l think it is also missing
char devpath[12];
snprintf(devpath, 12, "/dev/light%d", devno);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/arm/stm32/common/src/stm32_bh1750.c: fix include [nuttx]
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #12241:
URL: https://github.com/apache/nuttx/pull/12241#discussion_r1582255523
##########
boards/arm/stm32/common/src/stm32_bh1750.c:
##########
@@ -61,21 +61,22 @@
int board_bh1750_initialize(int devno, int busno)
{
struct i2c_master_s *i2c;
+ char devpath[12];
int ret;
sninfo("Initializing BH1750FVI!\n");
/* Initialize I2C */
i2c = stm32_i2cbus_initialize(busno);
-
if (!i2c)
{
return -ENODEV;
}
/* Then register the ambient light sensor */
+ snprintf(devpath, 12, "/dev/light%d", devno);
Review Comment:
`12`->`sizeof(devpath)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/arm/stm32/common/src/stm32_bh1750.c: fix include [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12241:
URL: https://github.com/apache/nuttx/pull/12241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org