You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2017/07/25 23:11:33 UTC

[Impala-ASF-CR] CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala

kkalyan@cloudera.com has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7507

Change subject: CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala
......................................................................

CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala

Conflicts:
	bin/impala-config-branch.sh

Change-Id: I666809a37cdaca28dc754c9b2ff7830b3ff475b7
---
M bin/impala-config-branch.sh
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/7507/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I666809a37cdaca28dc754c9b2ff7830b3ff475b7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: kkalyan@cloudera.com

[Impala-ASF-CR] CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7507/2//COMMIT_MSG
Commit Message:

PS2, Line 7: CDH-56987
> Please file an upstream Apache IMPALA JIRA. The context for the changes her
I've been talking to Kalyan out-of-band. He was able to use Cloudera's infrastructure to figure out the required changes for the new sentry APIs for the current development version of Sentry 2.0 (I don't think it's been released yet so it isn't set in stone).

I filed IMPALA-5728


-- 
To view, visit http://gerrit.cloudera.org:8080/7507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I666809a37cdaca28dc754c9b2ff7830b3ff475b7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: kkalyan@cloudera.com
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7507/2//COMMIT_MSG
Commit Message:

PS2, Line 7: CDH-56987
Please file an upstream Apache IMPALA JIRA. The context for the changes here need to be understood (on Apache Jira) before this can be reviewed. I don't understand why this change is in impala-config-branch.sh rather than impala-config.sh.


-- 
To view, visit http://gerrit.cloudera.org:8080/7507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I666809a37cdaca28dc754c9b2ff7830b3ff475b7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: kkalyan@cloudera.com
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has abandoned this change.

Change subject: CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala
......................................................................


Abandoned

Will abandon these for now, but they are a nice reference for the required changes.

-- 
To view, visit http://gerrit.cloudera.org:8080/7507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I666809a37cdaca28dc754c9b2ff7830b3ff475b7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: kkalyan@cloudera.com
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>