You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "李壮壮 (Jira)" <ji...@apache.org> on 2021/09/26 01:51:00 UTC
[jira] [Updated] (KAFKA-13323) The words are ambiguous
[ https://issues.apache.org/jira/browse/KAFKA-13323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
李壮壮 updated KAFKA-13323:
------------------------
Description:
In 'Fetcher' class, there is a field means consumer client should record whether the cached subscriptions have fetchPosition in order to do 'updateFetchPositions' action.
but the words 'cachedSubscriptionHashAllFetchPositions' are ambiguous. there should not has 'hash' function, i mean it should be replcaed by 'cachedSubscriptionHasAllFetchPositions'.
the code lists following
----------------------
// to keep from repeatedly scanning subscriptions in poll(), cache the result during metadata updates
private boolean cachedSubscriptionHashAllFetchPositions;
----------------------
was:
In 'Fether' class, there is a field means consumer client should record whether the cached subscriptions have fetchPosition in order to do 'updateFetchPositions' action.
but the words 'cachedSubscriptionHashAllFetchPositions' are ambiguous. there should not has 'hash' function, i mean it should be replcaed by 'cachedSubscriptionHasAllFetchPositions'.
the code lists following
----------------------
// to keep from repeatedly scanning subscriptions in poll(), cache the result during metadata updates
private boolean cachedSubscriptionHashAllFetchPositions;
----------------------
> The words are ambiguous
> -----------------------
>
> Key: KAFKA-13323
> URL: https://issues.apache.org/jira/browse/KAFKA-13323
> Project: Kafka
> Issue Type: Improvement
> Components: clients
> Affects Versions: 2.0.0, 3.0.0
> Reporter: 李壮壮
> Priority: Trivial
>
> In 'Fetcher' class, there is a field means consumer client should record whether the cached subscriptions have fetchPosition in order to do 'updateFetchPositions' action.
> but the words 'cachedSubscriptionHashAllFetchPositions' are ambiguous. there should not has 'hash' function, i mean it should be replcaed by 'cachedSubscriptionHasAllFetchPositions'.
>
> the code lists following
> ----------------------
> // to keep from repeatedly scanning subscriptions in poll(), cache the result during metadata updates
> private boolean cachedSubscriptionHashAllFetchPositions;
> ----------------------
--
This message was sent by Atlassian Jira
(v8.3.4#803005)