You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/01 03:20:02 UTC

[GitHub] [arrow-rs] Jimexist opened a new pull request, #3249: update `&Option` to `Option<&T>`

Jimexist opened a new pull request, #3249:
URL: https://github.com/apache/arrow-rs/pull/3249

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
   `Option<&T>` is more usable than `&Option<T>` and can be easily converted.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ursabot commented on pull request #3249: update `&Option` to `Option<&T>`

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3249:
URL: https://github.com/apache/arrow-rs/pull/3249#issuecomment-1333648886

   Benchmark runs are scheduled for baseline = c5c34fa43141d01709485d3a008d3df93262c49c and contender = f133621d0f56ebbf23392f9119349d0201bf51cd. f133621d0f56ebbf23392f9119349d0201bf51cd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/88d19967f7f348949d381a4511cc8a51...8bc594025cf54d339c736e46c89eecc2/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/924b66426c9446789aa67a44c7f7908d...86a914078de847458db475ec1b90b103/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1137918d83204c3d85b81a549ae60ab1...899fcf01c37b4037b94ab10a0becf56d/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1303b0be95404fd38abb34f1f564da5b...acaa4e4131e24a24b59c595c4012399a/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3249: update `&Option` to `Option<&T>`

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3249:
URL: https://github.com/apache/arrow-rs/pull/3249#discussion_r1036997075


##########
parquet/src/file/metadata.rs:
##########
@@ -277,8 +277,8 @@ impl RowGroupMetaData {
     }
 
     /// Returns reference of page offset index of all column in this row group.
-    pub fn page_offset_index(&self) -> &Option<Vec<Vec<PageLocation>>> {

Review Comment:
   This is technically an API change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #3249: update `&Option` to `Option<&T>`

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3249:
URL: https://github.com/apache/arrow-rs/pull/3249


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org