You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2020/06/18 05:32:18 UTC
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16094
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Impala save timestamp as 12 bytes of structure TimestampValue with
time in nano seconds. Kudu store timestamp as 8 bytes of Unix Time
microseconds. To avoid the data truncation issue in the bloom filter,
define TimestampTruncationExpr expression, and use it as the root
of source expression of bloom filter to convert timestamp as
microseconds when building bloom filter for Kudu.
Generated functional date_tbl table in Kudu format for unit-test.
Added new test cases for Kudu Timestamp and Date bloom filters.
Testing:
Passed test_runtime_filters.py, test_kudu.py and Planner test.
Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
---
M be/src/exprs/CMakeLists.txt
M be/src/exprs/scalar-expr.cc
M be/src/exprs/scalar-expr.h
A be/src/exprs/timestamp-truncation-expr.cc
A be/src/exprs/timestamp-truncation-expr.h
M common/thrift/Exprs.thrift
A fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test
M testdata/workloads/functional-query/queries/QueryTest/all_runtime_filters.test
12 files changed, 363 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/16094/1
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6382/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jun 2020 22:06:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16094/4/fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java
File fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java:
http://gerrit.cloudera.org:8080/#/c/16094/4/fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java@41
PS4, Line 41: public class TimestampTruncationExpr extends Expr {
So I'm sorry I didn't think of this before and wasted your time, but I realized I don't think this is actually necessary.
There's an existing function called 'utc_to_unix_micros' that does exactly what you're doing here. All you should need to do is create a FunctionCallExpr with that function name in RuntimeFilterGenerator.
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2020 20:27:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16094/4/fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java
File fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java:
http://gerrit.cloudera.org:8080/#/c/16094/4/fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java@41
PS4, Line 41: public class TimestampTruncationExpr extends Expr {
> So I'm sorry I didn't think of this before and wasted your time, but I real
Right, the code change will be much more simple and don't need to make any change in backend. Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2020 22:18:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/16094/3/be/src/exprs/timestamp-truncation-expr.h
File be/src/exprs/timestamp-truncation-expr.h:
http://gerrit.cloudera.org:8080/#/c/16094/3/be/src/exprs/timestamp-truncation-expr.h@18
PS3, Line 18: #ifndef IMPALA_EXPRS_TIMESTAMP_TRUNCATION_EXPR_H_
We prefer to use '#pragma once' for new code
http://gerrit.cloudera.org:8080/#/c/16094/3/be/src/exprs/timestamp-truncation-expr.h@30
PS3, Line 30: The children of this Expr
Probably worth specifying that this should have exactly one child.
http://gerrit.cloudera.org:8080/#/c/16094/3/common/thrift/Exprs.thrift
File common/thrift/Exprs.thrift:
http://gerrit.cloudera.org:8080/#/c/16094/3/common/thrift/Exprs.thrift@151
PS3, Line 151: struct TTimestampTruncationExpr {
Since this doesn't contain anything, its fine to just not include it.
It's already for case for example for NULL_LITERAL that there isn't a corresponding TNullLiteral.
http://gerrit.cloudera.org:8080/#/c/16094/3/fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java
File fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java:
http://gerrit.cloudera.org:8080/#/c/16094/3/fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java@30
PS3, Line 30: The children
Probably worth specifying that this will have exactly one child.
http://gerrit.cloudera.org:8080/#/c/16094/3/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java:
http://gerrit.cloudera.org:8080/#/c/16094/3/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@347
PS3, Line 347: // Don't create bloom filter targeting for HDFS scan node if the source
: // scan slot is Kudu timestamp slot since the timestamp values stored
: // in Kudu table are truncated and maybe different from the values stored
: // in the HDFS tables.
I think this needs more thought. There's two things we need to worry about when deciding to generate/assign a runtime filter: that it isn't going to change the final results of the query, and that its likely to produce a perf improvement.
The perf improvement part is already handled by the logic around cardinality and limits on the number of bloom filters and stuff, so the only reason to do this is if generating these filters would change the output of queries.
My understanding would be that prior to this patch we would generate filters like this (since we were already generating bloom filters targeting HDFS timestamp columns, and we don't currently consider the source those timestamps are coming from). So is the implication of this that there's a bug currently, i.e. are the Kudu timestamp -> HDFS timestamp bloom filters that would get generated right now resulting in queries returning incorrect values?
If so, then of course we should fix it (and probably also file a JIRA for it so that users that run into it can find info about it). If not, then we should leave it as is.
As you say, its might not be a good idea to do a join of a Kudu table and an HDFS table on a timestamp column because the timestamps are probably not going to match, but that's not our problem its the users problem, and its not necessarily always going to be the case eg. it might be that the HDFS table was generated by doing a "select *" from a Kudu table, in which case the timestamps will match up (this is a common pattern since Kudu is better for collecting a lot of small inserts, then the data gets moved in bulk to an HDFS table for archiving)
http://gerrit.cloudera.org:8080/#/c/16094/3/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@658
PS3, Line 658: true
We sometimes specify the names of parameters in a comment when the value is a constant like this, eg. "..., /* isTimestampTruncation */ true);"
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 15:48:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Impala save timestamp as 12 bytes of structure TimestampValue with
time in nano seconds. Kudu store timestamp as 8 bytes of Unix Time
microseconds. To avoid the data truncation issue in the bloom filter,
add FunctionCallExpr with 'utc_to_unix_micros' as the root of source
expression of bloom filter to convert timestamp values to microseconds
when building timestamp bloom filter for Kudu.
Generated functional date_tbl table in Kudu format for unit-test.
Added new test cases for Kudu Timestamp and Date bloom filters.
Testing:
Passed all core tests.
Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
---
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test
M testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test
M testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test
M testdata/workloads/functional-query/queries/QueryTest/all_runtime_filters.test
7 files changed, 299 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/16094/5
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2020 06:56:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Impala save timestamp as 12 bytes of structure TimestampValue with
time in nano seconds. Kudu store timestamp as 8 bytes of Unix Time
microseconds. To avoid the data truncation issue in the bloom filter,
define TimestampTruncationExpr expression, and add it as the root
of source expression of bloom filter to convert timestamp values to
microseconds when building timestamp bloom filter for Kudu.
Generated functional date_tbl table in Kudu format for unit-test.
Added new test cases for Kudu Timestamp and Date bloom filters.
Testing:
Passed all core tests.
Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
---
M be/src/exprs/CMakeLists.txt
M be/src/exprs/scalar-expr.cc
M be/src/exprs/scalar-expr.h
A be/src/exprs/timestamp-truncation-expr.cc
A be/src/exprs/timestamp-truncation-expr.h
M common/thrift/Exprs.thrift
A fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test
M testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test
M testdata/workloads/functional-query/queries/QueryTest/all_runtime_filters.test
13 files changed, 501 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/16094/2
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2020 01:57:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/16094/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java:
http://gerrit.cloudera.org:8080/#/c/16094/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@199
PS5, Line 199: // If set, indicates that the filter need to truncate timestamp.
mention that this is for Kudu
http://gerrit.cloudera.org:8080/#/c/16094/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@346
PS5, Line 346: return null;
Lets add a Log.warn with the error message here.
http://gerrit.cloudera.org:8080/#/c/16094/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@644
PS5, Line 644: if (filterType == TRuntimeFilterType.BLOOM
Add a brief comment here saying something like "For timestamp bloom filters we also generate a RuntimeFilter with the src timestamp truncated for Kudu scan node targets"
http://gerrit.cloudera.org:8080/#/c/16094/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@773
PS5, Line 773: targetExpr.getType().isTimestamp() && !filter.isTimestampTruncation()
I think it would make this 'if' clearer if you surrounded this with parentheses, to show that these conditions are related.
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2020 00:00:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6426/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2020 23:11:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6054/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2020 01:57:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6427/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2020 01:43:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6384/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Jun 2020 00:13:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Impala save timestamp as 12 bytes of structure TimestampValue with
time in nano seconds. Kudu store timestamp as 8 bytes of Unix Time
microseconds. To avoid the data truncation issue in the bloom filter,
define TimestampTruncationExpr expression, and add it as the root
of source expression of bloom filter to convert timestamp values to
microseconds when building timestamp bloom filter for Kudu.
Generated functional date_tbl table in Kudu format for unit-test.
Added new test cases for Kudu Timestamp and Date bloom filters.
Testing:
Passed all core tests.
Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
---
M be/src/exprs/CMakeLists.txt
M be/src/exprs/scalar-expr.cc
M be/src/exprs/scalar-expr.h
A be/src/exprs/timestamp-truncation-expr.cc
A be/src/exprs/timestamp-truncation-expr.h
M common/thrift/Exprs.thrift
A fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test
M testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test
M testdata/workloads/functional-query/queries/QueryTest/all_runtime_filters.test
13 files changed, 504 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/16094/3
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Impala save timestamp as 12 bytes of structure TimestampValue with
time in nano seconds. Kudu store timestamp as 8 bytes of Unix Time
microseconds. To avoid the data truncation issue in the bloom filter,
define TimestampTruncationExpr expression, and add it as the root
of source expression of bloom filter to convert timestamp values to
microseconds when building timestamp bloom filter for Kudu.
Generated functional date_tbl table in Kudu format for unit-test.
Added new test cases for Kudu Timestamp and Date bloom filters.
Testing:
Passed all core tests.
Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
---
M be/src/exprs/CMakeLists.txt
M be/src/exprs/scalar-expr.cc
M be/src/exprs/scalar-expr.h
A be/src/exprs/timestamp-truncation-expr.cc
A be/src/exprs/timestamp-truncation-expr.h
M common/thrift/Exprs.thrift
A fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test
M testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test
M testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test
M testdata/workloads/functional-query/queries/QueryTest/all_runtime_filters.test
14 files changed, 487 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/16094/4
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/16094/3/be/src/exprs/timestamp-truncation-expr.h
File be/src/exprs/timestamp-truncation-expr.h:
http://gerrit.cloudera.org:8080/#/c/16094/3/be/src/exprs/timestamp-truncation-expr.h@18
PS3, Line 18: #ifndef IMPALA_EXPRS_TIMESTAMP_TRUNCATION_EXPR_H_
> We prefer to use '#pragma once' for new code
Fixed it
http://gerrit.cloudera.org:8080/#/c/16094/3/be/src/exprs/timestamp-truncation-expr.h@30
PS3, Line 30: The children of this Expr
> Probably worth specifying that this should have exactly one child.
Fixed it
http://gerrit.cloudera.org:8080/#/c/16094/3/common/thrift/Exprs.thrift
File common/thrift/Exprs.thrift:
http://gerrit.cloudera.org:8080/#/c/16094/3/common/thrift/Exprs.thrift@151
PS3, Line 151: struct TTimestampTruncationExpr {
> Since this doesn't contain anything, its fine to just not include it.
removed it.
http://gerrit.cloudera.org:8080/#/c/16094/3/fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java
File fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java:
http://gerrit.cloudera.org:8080/#/c/16094/3/fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java@30
PS3, Line 30: The children
> Probably worth specifying that this will have exactly one child.
fixed it.
http://gerrit.cloudera.org:8080/#/c/16094/3/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java:
http://gerrit.cloudera.org:8080/#/c/16094/3/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@347
PS3, Line 347: // Don't create bloom filter targeting for HDFS scan node if the source
: // scan slot is Kudu timestamp slot since the timestamp values stored
: // in Kudu table are truncated and maybe different from the values stored
: // in the HDFS tables.
> I think this needs more thought. There's two things we need to worry about
Removed this piece of code to keep current behavior.
http://gerrit.cloudera.org:8080/#/c/16094/3/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@658
PS3, Line 658: true
> We sometimes specify the names of parameters in a comment when the value is
Fixed it.
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 18:57:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Impala save timestamp as 12 bytes of structure TimestampValue with
time in nano seconds. Kudu store timestamp as 8 bytes of Unix Time
microseconds. To avoid the data truncation issue in the bloom filter,
add FunctionCallExpr with 'utc_to_unix_micros' as the root of source
expression of bloom filter to convert timestamp values to microseconds
when building timestamp bloom filter for Kudu.
Generated functional date_tbl table in Kudu format for unit-test.
Added new test cases for Kudu Timestamp and Date bloom filters.
Testing:
Passed all core tests.
Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
---
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test
M testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test
M testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test
M testdata/workloads/functional-query/queries/QueryTest/all_runtime_filters.test
7 files changed, 311 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/16094/6
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6363/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jun 2020 06:00:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6401/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 19:47:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/16094/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java:
http://gerrit.cloudera.org:8080/#/c/16094/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@199
PS5, Line 199: // If set, indicates that the filter is targeted for Kudu scan node with source
> mention that this is for Kudu
Ok, will fix it.
http://gerrit.cloudera.org:8080/#/c/16094/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@346
PS5, Line 346: } catch (AnalysisException e) {
> Lets add a Log.warn with the error message here.
Will add log message.
http://gerrit.cloudera.org:8080/#/c/16094/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@644
PS5, Line 644: joinNode, filterType, bloomFilterSizeLimits_,
> Add a brief comment here saying something like "For timestamp bloom filters
Will add comments.
http://gerrit.cloudera.org:8080/#/c/16094/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@773
PS5, Line 773: nue;
> I think it would make this 'if' clearer if you surrounded this with parenth
Will fix it.
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2020 01:16:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter
......................................................................
IMPALA-9691: Support Kudu Timestamp and Date bloom filter
Impala save timestamp as 12 bytes of structure TimestampValue with
time in nano seconds. Kudu store timestamp as 8 bytes of Unix Time
microseconds. To avoid the data truncation issue in the bloom filter,
add FunctionCallExpr with 'utc_to_unix_micros' as the root of source
expression of bloom filter to convert timestamp values to microseconds
when building timestamp bloom filter for Kudu.
Generated functional date_tbl table in Kudu format for unit-test.
Added new test cases for Kudu Timestamp and Date bloom filters.
Testing:
Passed all core tests.
Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Reviewed-on: http://gerrit.cloudera.org:8080/16094
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test
M testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test
M testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test
M testdata/workloads/functional-query/queries/QueryTest/all_runtime_filters.test
7 files changed, 311 insertions(+), 30 deletions(-)
Approvals:
Thomas Tauber-Marshall: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48
Gerrit-Change-Number: 16094
Gerrit-PatchSet: 7
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>