You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/10/04 22:40:53 UTC

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver 

Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11585


Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................

IMPALA-7660: Support ECDH ciphers for debug webserver

A recent change (IMPALA-7519) added support for ecdh ciphers for the
beeswax/hs2 server. This patch pulls in a recent change on squeasel to
extend that support to the debug webserver.

It also fixes a bug that prevented start-impala-cluster.py from
completing successfully when the webserver is launched with ssl, due
to it trying to verify the availablitiy of the webserver over http.

Testing:
- Added a custom cluster test that verifies start-impala-cluster.py
  runs successfully with webserver ssl enabled.
- Adds the webserver to an existing test for ecdh ciphers.

Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
4 files changed, 82 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/11585/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11585

to look at the new patch set (#3).

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................

IMPALA-7660: Support ECDH ciphers for debug webserver

A recent change (IMPALA-7519) added support for ecdh ciphers for the
beeswax/hs2 server. This patch pulls in a recent change on squeasel to
extend that support to the debug webserver.

It also fixes a bug that prevented start-impala-cluster.py from
completing successfully when the webserver is launched with ssl, due
to it trying to verify the availablitiy of the webserver over http.

Testing:
- Added a custom cluster test that verifies start-impala-cluster.py
  runs successfully with webserver ssl enabled.
- Adds the webserver to an existing test for ecdh ciphers.

Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
4 files changed, 86 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/11585/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3282/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 17:22:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 21:16:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/953/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 00:19:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/965/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 17:56:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 3: Code-Review+2

somehow dropped a few lines when I submitted it last, carrying forward


-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 17:22:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3273/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Oct 2018 23:44:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 17:22:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Oct 2018 22:49:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/948/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Oct 2018 23:12:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................

IMPALA-7660: Support ECDH ciphers for debug webserver

A recent change (IMPALA-7519) added support for ecdh ciphers for the
beeswax/hs2 server. This patch pulls in a recent change on squeasel to
extend that support to the debug webserver.

It also fixes a bug that prevented start-impala-cluster.py from
completing successfully when the webserver is launched with ssl, due
to it trying to verify the availablitiy of the webserver over http.

Testing:
- Added a custom cluster test that verifies start-impala-cluster.py
  runs successfully with webserver ssl enabled.
- Adds the webserver to an existing test for ecdh ciphers.

Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Reviewed-on: http://gerrit.cloudera.org:8080/11585
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
4 files changed, 86 insertions(+), 25 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11585/1/tests/custom_cluster/test_client_ssl.py
File tests/custom_cluster/test_client_ssl.py:

http://gerrit.cloudera.org:8080/#/c/11585/1/tests/custom_cluster/test_client_ssl.py@116
PS1, Line 116:  
flake8: E203 whitespace before ':'


http://gerrit.cloudera.org:8080/#/c/11585/1/tests/custom_cluster/test_client_ssl.py@134
PS1, Line 134:  
flake8: E203 whitespace before ':'



-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Oct 2018 22:41:36 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3273/


-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 01:22:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11585 )

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

carrying forward

http://gerrit.cloudera.org:8080/#/c/11585/1/tests/custom_cluster/test_client_ssl.py
File tests/custom_cluster/test_client_ssl.py:

http://gerrit.cloudera.org:8080/#/c/11585/1/tests/custom_cluster/test_client_ssl.py@116
PS1, Line 116: :
> flake8: E203 whitespace before ':'
Done


http://gerrit.cloudera.org:8080/#/c/11585/1/tests/custom_cluster/test_client_ssl.py@134
PS1, Line 134: :
> flake8: E203 whitespace before ':'
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Oct 2018 23:43:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7660: Support ECDH ciphers for debug webserver

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11585

to look at the new patch set (#2).

Change subject: IMPALA-7660: Support ECDH ciphers for debug webserver
......................................................................

IMPALA-7660: Support ECDH ciphers for debug webserver

A recent change (IMPALA-7519) added support for ecdh ciphers for the
beeswax/hs2 server. This patch pulls in a recent change on squeasel to
extend that support to the debug webserver.

It also fixes a bug that prevented start-impala-cluster.py from
completing successfully when the webserver is launched with ssl, due
to it trying to verify the availablitiy of the webserver over http.

Testing:
- Added a custom cluster test that verifies start-impala-cluster.py
  runs successfully with webserver ssl enabled.
- Adds the webserver to an existing test for ecdh ciphers.

Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
4 files changed, 82 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/11585/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80a6b370d5860812cde13229b5bcb2977814c73c
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>