You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:34:00 UTC
[GitHub] [airflow] potiuk opened a new pull request #16394: Helm chart upgrade ci
potiuk opened a new pull request #16394:
URL: https://github.com/apache/airflow/pull/16394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #16394: Helm chart upgrade ci
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #16394:
URL: https://github.com/apache/airflow/pull/16394#issuecomment-868983877
> Ha @ephraimbuddy ! I think I finally got it 🎉
Wonderful!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16394: Helm chart upgrade ci
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16394:
URL: https://github.com/apache/airflow/pull/16394#issuecomment-868736424
Yep. It works :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16394: Helm chart upgrade ci
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16394:
URL: https://github.com/apache/airflow/pull/16394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16394: Helm chart upgrade ci
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16394:
URL: https://github.com/apache/airflow/pull/16394#issuecomment-868732421
Ha @ephraimbuddy ! I think I finally got it 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #16394: Helm chart upgrade ci
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #16394:
URL: https://github.com/apache/airflow/pull/16394#issuecomment-867829654
> @ephraimbuddy - running it here. There are few small things I corrected (let's see if it helps):
>
> * I moved the common functions to _parallel.sh (and prefixed with `parallell::`)
> * I renamed the common functions to __helm__
> * I added the `>"${JOB_LOG}" 2>&1` redirection (that was the actual culprit for the failure you had - the output was simply printed directly to stdout for parallel jobs, rather than redirected to a separate log per parallell job. So when we tried to print the output after all jobs were finished, the JOB_LOG file was missing (and then it failed).
Cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16394: Helm chart upgrade ci
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16394:
URL: https://github.com/apache/airflow/pull/16394#issuecomment-867828936
@ephraimbuddy - running it here. There are few small things I corrected (let's see if it helps):
* I moved the common functions to _parallel.sh (and prefixed with `parallell::`)
* I renamed the common functions to *_helm_*
* I added the `>"${JOB_LOG}" 2>&1` redirection (that was the actual culprit for the failure you had - the output was simply printed directly to stdout for parallel jobs, rather than redirected to a separate log per parallell job. So when we tried to print the output after all jobs were finished, the JOB_LOG file was missing (and then it failed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16394: Helm chart upgrade ci
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16394:
URL: https://github.com/apache/airflow/pull/16394#issuecomment-868983960
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16394: Helm chart upgrade ci
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16394:
URL: https://github.com/apache/airflow/pull/16394#issuecomment-868328696
one more fix @ephraimbuddy :) - > the problem was that when we moved the function, scripts relative location changed and I had to change it to make it a "full" script path ( `"${AIRFLOW_SOURCES}/scripts/ci/kubernetes/${single_job_filename}"`). It was `"$(dirname "${BASH_SOURCE[0]}")/${single_job_filename}"`. I also added some better diagnostics in similar situations to make it more obvious what happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #16394: Helm chart upgrade ci
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #16394:
URL: https://github.com/apache/airflow/pull/16394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy closed pull request #16394: Helm chart upgrade ci
Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed pull request #16394:
URL: https://github.com/apache/airflow/pull/16394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org