[GitHub] [netbeans] jlahoda commented on pull request #3160: ConvertTextBlockToString warning should be a hint/suggestion

[GitBox <gi...@apache.org>]

jlahoda commented on pull request #3160:
URL: https://github.com/apache/netbeans/pull/3160#issuecomment-916640622


   Thanks for tackling this. The changes to the messages are great. For the hint, I guess I agree it should be on one line only (or, as far as I am concerned, disabled). But if it is a suggestion/`Hint.Kind.ACTION`, it will not be usable in Inspect&Transform, which is not much desirable.
   
   So, my suggestion would be:
   -keep the `severity = Severity.HINT`, that should make the hint work on the current line only
   -drop both `minSourceVersion = "13"` (as it does not make sense anyway) and `hintKind = Hint.Kind.ACTION`
   -change the category to `rules15`
   
   I think this should make the warning appear only if the caret is inside the span that would be converted. There may be some infrastructure changes that would make the appearance even better, but that does not need to be done here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists