[jira] [Work logged] (BEAM-14522) ProtoSchemaTranslator creates NOT NULL beam schema fields even for optional proto fields

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-14522?focusedWorklogId=775308&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775308 ]

ASF GitHub Bot logged work on BEAM-14522:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/May/22 01:39
            Start Date: 27/May/22 01:39
    Worklog Time Spent: 10m 
      Work Description: nbali closed pull request #17764: [BEAM-14522] Fix for creating NOT NULL beam schema fields for optional proto fields
URL: https://github.com/apache/beam/pull/17764




Issue Time Tracking
-------------------

            Worklog Id:     (was: 775308)
    Remaining Estimate: 0h
            Time Spent: 10m

> ProtoSchemaTranslator creates NOT NULL beam schema fields even for optional proto fields
> ----------------------------------------------------------------------------------------
>
>                 Key: BEAM-14522
>                 URL: https://issues.apache.org/jira/browse/BEAM-14522
>             Project: Beam
>          Issue Type: Bug
>          Components: extensions-java-protobuf
>            Reporter: Balázs Németh
>            Priority: P2
>             Fix For: Not applicable
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> ProtoSchemaTranslator is capable of creating Beam schemas (org.apache.beam.sdk.schemas.Schema) from proto classes. The problem is that the code that transforms the non-null org.apache.beam.sdk.schemas.Schema.FieldType into a nullable one is at a wrong place. Instead of doing it for every type for every field that is optional at the proto class after the switch-case it is actually inside the switch-case and only does it for MESSAGE and GROUP types.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)