You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2014/11/18 02:46:15 UTC

Review Request 28144: Configs: UI breaks during particular flow

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28144/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-8361
    https://issues.apache.org/jira/browse/AMBARI-8361


Repository: ambari


Description
-------

Configs UI breaks with the following flow:

1) go to tez
2) edit tez.am.resource.memory.mb and make 1
3) click save
4) that prompts the warning that this is not a recommended value
5) click cancel
6) browse to pig
7) you are prompted you have unsaved changes, click discard
9) Pig configs ui ends up broken

have to browse away and come back for it to straighten out. See attached for example of broken-ness


Diffs
-----

  ambari-web/app/controllers/main/service/info/configs.js 9333084 

Diff: https://reviews.apache.org/r/28144/diff/


Testing
-------

Patch tested in different cases. Unit tests passed


Thanks,

Xi Wang

Re: Review Request 28144: Configs: UI breaks during particular flow

Posted by Jaimin Jetly <ja...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28144/#review62660
-----------------------------------------------------------

Ship it!


Ship It!

- Jaimin Jetly


On Nov. 18, 2014, 1:46 a.m., Xi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28144/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 1:46 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8361
>     https://issues.apache.org/jira/browse/AMBARI-8361
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Configs UI breaks with the following flow:
> 
> 1) go to tez
> 2) edit tez.am.resource.memory.mb and make 1
> 3) click save
> 4) that prompts the warning that this is not a recommended value
> 5) click cancel
> 6) browse to pig
> 7) you are prompted you have unsaved changes, click discard
> 9) Pig configs ui ends up broken
> 
> have to browse away and come back for it to straighten out. See attached for example of broken-ness
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/info/configs.js 9333084 
> 
> Diff: https://reviews.apache.org/r/28144/diff/
> 
> 
> Testing
> -------
> 
> Patch tested in different cases. Unit tests passed
> 
> 
> Thanks,
> 
> Xi Wang
> 
>