You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@rya.apache.org by ejwhite922 <gi...@git.apache.org> on 2018/01/05 17:03:20 UTC

[GitHub] incubator-rya issue #253: RYA-413 Fixed how MongoDBRyaDAO closed its interna...

Github user ejwhite922 commented on the issue:

    https://github.com/apache/incubator-rya/pull/253
  
    Rebased this review off RYA-303.  Only the latest commit should be review "RYA-413 Fixed how MongoDBRyaDAO..."
    
    The main change is removing mongoClient.close() from MongoDBRyaDAO.destroy().  This may or may not be desirable.  Should the mongoClient be closed from StatefulMongoDBRdfConfiguration when the JVM shuts down?  I only see EmbeddedMongoSingleton closing the mongoClient but it appears that's only used for testing.


---