You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/13 23:59:13 UTC

[GitHub] [beam] tvalentyn edited a comment on pull request #13175: Adding performance improvements to ApproximateQuantiles.

tvalentyn edited a comment on pull request #13175:
URL: https://github.com/apache/beam/pull/13175#issuecomment-759833658


   Took a quick look, I think I'd have to read through the original paper to make an informed opinion on the change; unless @iindyk has a reviewer in mind who is already familiar with the algorithm, I am happy to take a look. It will take me a bit of time to get up to speed on algorithm, but it looks interesting.
   @iindyk - are the optimizations in this PR also described in [MRL98], or your change is an optimization on top of that algorithm? Also, would you mind splitting the proposed optimizations into individual commits (or PRs), one commit per optimization if that's possible? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org