You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/03/06 23:52:25 UTC
Review Request 65938: Replaced "re-register" terminology with
"reregister".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65938/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Bugs: MESOS-6128
https://issues.apache.org/jira/browse/MESOS-6128
Repository: mesos
Description
-------
We sometimes use "re-register" in comments and elsewhere we
use "reregister". We should pick the "reregister" form and
use it consistently.
Diffs
-----
CHANGELOG 20bfe210d1b9b027a3be0712fe71c560b177d061
docs/agent-recovery.md 8df72cb3adfec9f52429b88c19c437c6fe3d5fd9
docs/app-framework-development-guide.md e31bffc78daffa9f82ecf5361f91281354f9e466
docs/configuration/agent.md 71e5a86cbed6cd646c398800889308bc2912083f
docs/configuration/master.md 7b2bb98c43e7f419e6bbe28fdb0f3d1946557165
docs/high-availability-framework-guide.md f2467735bfc4c47c21d108c50f74aea4d302e252
docs/high-availability.md 1bad0ee6ddeebbf47dbc0c202c28cdec3000fb75
docs/maintenance.md 88434e843279626ef89c61c3f70cc9da54b3eee8
docs/monitoring.md 7ad15b4f821108083b5f9f4381c33d5f465d361b
docs/operator-http-api.md 64110f03ad3158765f8b928a68d004e1f296d4c8
docs/reconciliation.md 473e3e2ad08ae0154c3d84cd72de076a3922638e
docs/roles.md ddea114baed0e378b43fd7a9462787cf0689216c
docs/task-state-reasons.md 5f7f8d2eeb91d47c44bdf665fe31eb474933c2de
include/mesos/authorizer/acls.proto 086274388ace3a60c68cca1a37507af3ec429bf8
include/mesos/executor.hpp 68cba9e3c411eb9f396b49adcc9d71137a5d948c
include/mesos/master/master.proto f40caa2a6338ff58a325444cfb72cd24f2c99472
include/mesos/mesos.proto 2c5ae4cd8d9cfaabd42a9e94ce94cd73bfacc6eb
include/mesos/scheduler.hpp 423235a90166e71866a88baa3bf16ba551010c5c
include/mesos/scheduler/scheduler.proto 7a90355c3d1a362ebb4fdb63bfe1fba8aca60d5b
include/mesos/v1/master/master.proto 67c9560eaa7bd6b20b73af07f7666f0d98c4453d
include/mesos/v1/mesos.proto 67080ed2907a2fee53dab4802dce0aeac3424412
site/source/blog/2013-10-23-slave-recovery-in-apache-mesos.md 5b604f591d20b08cf4329f7503eaa4d137e5ed85
site/source/blog/2014-06-12-mesos-0-19-0-released.md 2d2a3db21580422761cd1895b5aab5c894c7e72f
site/source/blog/2017-09-18-mesos-1-4-0-released.md fcdc2e426ef95e4ee90f6a637ac083aa6d0f2cf7
site/source/blog/2017-12-07-performance-working-group-progress-report.md b7f5a8786953f54b63704e09c23528003052f695
src/exec/exec.cpp 0c76a3f1d05b3ff93b04a2bf4ac6a9f433dd1d19
src/java/src/org/apache/mesos/Executor.java 078c0c7ea3ad68e9b4b40802c3d6b94084cbb69b
src/java/src/org/apache/mesos/Scheduler.java cb5a65872fa4bbd711c86af258e58aa7b33777b8
src/master/allocator/mesos/hierarchical.cpp e0ab8360c282092b141a12e8628f3d08039a0b69
src/master/constants.hpp 17092ea1b43a3fa86fbbcb4dff6b24922054ae12
src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb
src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35
src/python/executor/src/mesos/executor/proxy_executor.cpp 2462ccb3be1f7e0078448bfe0e1dc577c859422f
src/python/interface/src/mesos/interface/__init__.py 048eb6438d204aa20d71a8d59f516f06934f2d99
src/sched/sched.cpp 81aa0d7d34753be2bac49753be1ab3be21746d5d
src/slave/constants.hpp b79c084f4952affec531f29797479f3e702a66b6
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp f1d377eb911fb6a0ca3a4749a0e00d5166f35129
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp df240bcff9e53faab275ac41ba3221789467dca6
src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
src/slave/slave.hpp f161369732932ec99abbf635f91c88425744b3a9
src/slave/slave.cpp 8cb6899bf15fb697c3cb2784f63b7c2d5729d219
src/slave/task_status_update_manager.cpp 24d803d5ba0dab5c0ca5316cf2affedba3a6e65e
src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c
src/tests/authentication_tests.cpp 3c6124f641b64cb6f67cb1605958e12151b91456
src/tests/containerizer/docker_containerizer_tests.cpp 85e6f8739dd2d6f9119e30f13f681cf4b8dc45ed
src/tests/containerizer/docker_volume_isolator_tests.cpp 9123cbe50e4a3417dc4f205092a436d7230c7414
src/tests/containerizer/memory_pressure_tests.cpp 488051dbf85a9d0baf5f61b8c0d28aa14dad9427
src/tests/containerizer/ports_isolator_tests.cpp 0969cf545254c6cadfd69fa0f4f4f087f07af4b7
src/tests/containerizer/xfs_quota_tests.cpp ce69c882251c36cf50dc1b46dd0b9337bb7b5043
src/tests/disk_quota_tests.cpp db53108ebe3fb67b8a69a0e2925159f7b5965efb
src/tests/fault_tolerance_tests.cpp 64a865339cc0dad1bc43aea40c6491d0ece6e48a
src/tests/fetcher_cache_tests.cpp 4d9e5d83279ef706b1b91d1dcf4f13f59e276749
src/tests/gc_tests.cpp bff3c0530441d378c8cebc4e5539d603bb1b8810
src/tests/master_allocator_tests.cpp 43f1c7183fc1016e037af83dd6f4f1423a8c74c6
src/tests/master_authorization_tests.cpp 8e526fc80062c56c91a62782d242de5dfed64e96
src/tests/master_slave_reconciliation_tests.cpp 0541aa56a414fbec872e7e3ec6ad50206766054a
src/tests/master_tests.cpp 8be43f332013d59493623eccf4e410d2f0bd6870
src/tests/oversubscription_tests.cpp 41c1178ec4514ef6a1fb369734d4f9d73710d883
src/tests/partition_tests.cpp a9036a1eb0bd0e803425caa373cce77b6e40aeb9
src/tests/persistent_volume_tests.cpp 4cb2c95f2af059e827f10349f2dd29713d8b368c
src/tests/slave_recovery_tests.cpp 5a3f19f601ef2e72cadca0426c4e9e5457836db8
src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226
src/tests/storage_local_resource_provider_tests.cpp c2fcbf32936ef1cb6fd313eac7e3c9c5de99c1fc
src/tests/teardown_tests.cpp 392cacfaefb365cb299382488aca3f8c8e2c0392
src/tests/upgrade_tests.cpp dd73d730bf8f0ae69ed5280a459e2c9534a54a49
Diff: https://reviews.apache.org/r/65938/diff/1/
Testing
-------
make check (Fedora 27).
Thanks,
James Peach
Re: Review Request 65938: Replaced "re-register" terminology with
"reregister".
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65938/#review198754
-----------------------------------------------------------
PASS: Mesos patch 65938 was successfully built and tested.
Reviews applied: `['65938']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65938
- Mesos Reviewbot Windows
On March 6, 2018, 11:52 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65938/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 11:52 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-6128
> https://issues.apache.org/jira/browse/MESOS-6128
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We sometimes use "re-register" in comments and elsewhere we
> use "reregister". We should pick the "reregister" form and
> use it consistently.
>
>
> Diffs
> -----
>
> CHANGELOG 20bfe210d1b9b027a3be0712fe71c560b177d061
> docs/agent-recovery.md 8df72cb3adfec9f52429b88c19c437c6fe3d5fd9
> docs/app-framework-development-guide.md e31bffc78daffa9f82ecf5361f91281354f9e466
> docs/configuration/agent.md 71e5a86cbed6cd646c398800889308bc2912083f
> docs/configuration/master.md 7b2bb98c43e7f419e6bbe28fdb0f3d1946557165
> docs/high-availability-framework-guide.md f2467735bfc4c47c21d108c50f74aea4d302e252
> docs/high-availability.md 1bad0ee6ddeebbf47dbc0c202c28cdec3000fb75
> docs/maintenance.md 88434e843279626ef89c61c3f70cc9da54b3eee8
> docs/monitoring.md 7ad15b4f821108083b5f9f4381c33d5f465d361b
> docs/operator-http-api.md 64110f03ad3158765f8b928a68d004e1f296d4c8
> docs/reconciliation.md 473e3e2ad08ae0154c3d84cd72de076a3922638e
> docs/roles.md ddea114baed0e378b43fd7a9462787cf0689216c
> docs/task-state-reasons.md 5f7f8d2eeb91d47c44bdf665fe31eb474933c2de
> include/mesos/authorizer/acls.proto 086274388ace3a60c68cca1a37507af3ec429bf8
> include/mesos/executor.hpp 68cba9e3c411eb9f396b49adcc9d71137a5d948c
> include/mesos/master/master.proto f40caa2a6338ff58a325444cfb72cd24f2c99472
> include/mesos/mesos.proto 2c5ae4cd8d9cfaabd42a9e94ce94cd73bfacc6eb
> include/mesos/scheduler.hpp 423235a90166e71866a88baa3bf16ba551010c5c
> include/mesos/scheduler/scheduler.proto 7a90355c3d1a362ebb4fdb63bfe1fba8aca60d5b
> include/mesos/v1/master/master.proto 67c9560eaa7bd6b20b73af07f7666f0d98c4453d
> include/mesos/v1/mesos.proto 67080ed2907a2fee53dab4802dce0aeac3424412
> site/source/blog/2013-10-23-slave-recovery-in-apache-mesos.md 5b604f591d20b08cf4329f7503eaa4d137e5ed85
> site/source/blog/2014-06-12-mesos-0-19-0-released.md 2d2a3db21580422761cd1895b5aab5c894c7e72f
> site/source/blog/2017-09-18-mesos-1-4-0-released.md fcdc2e426ef95e4ee90f6a637ac083aa6d0f2cf7
> site/source/blog/2017-12-07-performance-working-group-progress-report.md b7f5a8786953f54b63704e09c23528003052f695
> src/exec/exec.cpp 0c76a3f1d05b3ff93b04a2bf4ac6a9f433dd1d19
> src/java/src/org/apache/mesos/Executor.java 078c0c7ea3ad68e9b4b40802c3d6b94084cbb69b
> src/java/src/org/apache/mesos/Scheduler.java cb5a65872fa4bbd711c86af258e58aa7b33777b8
> src/master/allocator/mesos/hierarchical.cpp e0ab8360c282092b141a12e8628f3d08039a0b69
> src/master/constants.hpp 17092ea1b43a3fa86fbbcb4dff6b24922054ae12
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb
> src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35
> src/python/executor/src/mesos/executor/proxy_executor.cpp 2462ccb3be1f7e0078448bfe0e1dc577c859422f
> src/python/interface/src/mesos/interface/__init__.py 048eb6438d204aa20d71a8d59f516f06934f2d99
> src/sched/sched.cpp 81aa0d7d34753be2bac49753be1ab3be21746d5d
> src/slave/constants.hpp b79c084f4952affec531f29797479f3e702a66b6
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp f1d377eb911fb6a0ca3a4749a0e00d5166f35129
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp df240bcff9e53faab275ac41ba3221789467dca6
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/slave.hpp f161369732932ec99abbf635f91c88425744b3a9
> src/slave/slave.cpp 8cb6899bf15fb697c3cb2784f63b7c2d5729d219
> src/slave/task_status_update_manager.cpp 24d803d5ba0dab5c0ca5316cf2affedba3a6e65e
> src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c
> src/tests/authentication_tests.cpp 3c6124f641b64cb6f67cb1605958e12151b91456
> src/tests/containerizer/docker_containerizer_tests.cpp 85e6f8739dd2d6f9119e30f13f681cf4b8dc45ed
> src/tests/containerizer/docker_volume_isolator_tests.cpp 9123cbe50e4a3417dc4f205092a436d7230c7414
> src/tests/containerizer/memory_pressure_tests.cpp 488051dbf85a9d0baf5f61b8c0d28aa14dad9427
> src/tests/containerizer/ports_isolator_tests.cpp 0969cf545254c6cadfd69fa0f4f4f087f07af4b7
> src/tests/containerizer/xfs_quota_tests.cpp ce69c882251c36cf50dc1b46dd0b9337bb7b5043
> src/tests/disk_quota_tests.cpp db53108ebe3fb67b8a69a0e2925159f7b5965efb
> src/tests/fault_tolerance_tests.cpp 64a865339cc0dad1bc43aea40c6491d0ece6e48a
> src/tests/fetcher_cache_tests.cpp 4d9e5d83279ef706b1b91d1dcf4f13f59e276749
> src/tests/gc_tests.cpp bff3c0530441d378c8cebc4e5539d603bb1b8810
> src/tests/master_allocator_tests.cpp 43f1c7183fc1016e037af83dd6f4f1423a8c74c6
> src/tests/master_authorization_tests.cpp 8e526fc80062c56c91a62782d242de5dfed64e96
> src/tests/master_slave_reconciliation_tests.cpp 0541aa56a414fbec872e7e3ec6ad50206766054a
> src/tests/master_tests.cpp 8be43f332013d59493623eccf4e410d2f0bd6870
> src/tests/oversubscription_tests.cpp 41c1178ec4514ef6a1fb369734d4f9d73710d883
> src/tests/partition_tests.cpp a9036a1eb0bd0e803425caa373cce77b6e40aeb9
> src/tests/persistent_volume_tests.cpp 4cb2c95f2af059e827f10349f2dd29713d8b368c
> src/tests/slave_recovery_tests.cpp 5a3f19f601ef2e72cadca0426c4e9e5457836db8
> src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226
> src/tests/storage_local_resource_provider_tests.cpp c2fcbf32936ef1cb6fd313eac7e3c9c5de99c1fc
> src/tests/teardown_tests.cpp 392cacfaefb365cb299382488aca3f8c8e2c0392
> src/tests/upgrade_tests.cpp dd73d730bf8f0ae69ed5280a459e2c9534a54a49
>
>
> Diff: https://reviews.apache.org/r/65938/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 65938: Replaced "re-register" terminology with
"reregister".
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65938/#review198950
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On March 6, 2018, 11:52 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65938/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 11:52 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-6128
> https://issues.apache.org/jira/browse/MESOS-6128
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We sometimes use "re-register" in comments and elsewhere we
> use "reregister". We should pick the "reregister" form and
> use it consistently.
>
>
> Diffs
> -----
>
> CHANGELOG 20bfe210d1b9b027a3be0712fe71c560b177d061
> docs/agent-recovery.md 8df72cb3adfec9f52429b88c19c437c6fe3d5fd9
> docs/app-framework-development-guide.md e31bffc78daffa9f82ecf5361f91281354f9e466
> docs/configuration/agent.md 71e5a86cbed6cd646c398800889308bc2912083f
> docs/configuration/master.md 7b2bb98c43e7f419e6bbe28fdb0f3d1946557165
> docs/high-availability-framework-guide.md f2467735bfc4c47c21d108c50f74aea4d302e252
> docs/high-availability.md 1bad0ee6ddeebbf47dbc0c202c28cdec3000fb75
> docs/maintenance.md 88434e843279626ef89c61c3f70cc9da54b3eee8
> docs/monitoring.md 7ad15b4f821108083b5f9f4381c33d5f465d361b
> docs/operator-http-api.md 64110f03ad3158765f8b928a68d004e1f296d4c8
> docs/reconciliation.md 473e3e2ad08ae0154c3d84cd72de076a3922638e
> docs/roles.md ddea114baed0e378b43fd7a9462787cf0689216c
> docs/task-state-reasons.md 5f7f8d2eeb91d47c44bdf665fe31eb474933c2de
> include/mesos/authorizer/acls.proto 086274388ace3a60c68cca1a37507af3ec429bf8
> include/mesos/executor.hpp 68cba9e3c411eb9f396b49adcc9d71137a5d948c
> include/mesos/master/master.proto f40caa2a6338ff58a325444cfb72cd24f2c99472
> include/mesos/mesos.proto 2c5ae4cd8d9cfaabd42a9e94ce94cd73bfacc6eb
> include/mesos/scheduler.hpp 423235a90166e71866a88baa3bf16ba551010c5c
> include/mesos/scheduler/scheduler.proto 7a90355c3d1a362ebb4fdb63bfe1fba8aca60d5b
> include/mesos/v1/master/master.proto 67c9560eaa7bd6b20b73af07f7666f0d98c4453d
> include/mesos/v1/mesos.proto 67080ed2907a2fee53dab4802dce0aeac3424412
> site/source/blog/2013-10-23-slave-recovery-in-apache-mesos.md 5b604f591d20b08cf4329f7503eaa4d137e5ed85
> site/source/blog/2014-06-12-mesos-0-19-0-released.md 2d2a3db21580422761cd1895b5aab5c894c7e72f
> site/source/blog/2017-09-18-mesos-1-4-0-released.md fcdc2e426ef95e4ee90f6a637ac083aa6d0f2cf7
> site/source/blog/2017-12-07-performance-working-group-progress-report.md b7f5a8786953f54b63704e09c23528003052f695
> src/exec/exec.cpp 0c76a3f1d05b3ff93b04a2bf4ac6a9f433dd1d19
> src/java/src/org/apache/mesos/Executor.java 078c0c7ea3ad68e9b4b40802c3d6b94084cbb69b
> src/java/src/org/apache/mesos/Scheduler.java cb5a65872fa4bbd711c86af258e58aa7b33777b8
> src/master/allocator/mesos/hierarchical.cpp e0ab8360c282092b141a12e8628f3d08039a0b69
> src/master/constants.hpp 17092ea1b43a3fa86fbbcb4dff6b24922054ae12
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb
> src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35
> src/python/executor/src/mesos/executor/proxy_executor.cpp 2462ccb3be1f7e0078448bfe0e1dc577c859422f
> src/python/interface/src/mesos/interface/__init__.py 048eb6438d204aa20d71a8d59f516f06934f2d99
> src/sched/sched.cpp 81aa0d7d34753be2bac49753be1ab3be21746d5d
> src/slave/constants.hpp b79c084f4952affec531f29797479f3e702a66b6
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp f1d377eb911fb6a0ca3a4749a0e00d5166f35129
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp df240bcff9e53faab275ac41ba3221789467dca6
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/slave.hpp f161369732932ec99abbf635f91c88425744b3a9
> src/slave/slave.cpp 8cb6899bf15fb697c3cb2784f63b7c2d5729d219
> src/slave/task_status_update_manager.cpp 24d803d5ba0dab5c0ca5316cf2affedba3a6e65e
> src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c
> src/tests/authentication_tests.cpp 3c6124f641b64cb6f67cb1605958e12151b91456
> src/tests/containerizer/docker_containerizer_tests.cpp 85e6f8739dd2d6f9119e30f13f681cf4b8dc45ed
> src/tests/containerizer/docker_volume_isolator_tests.cpp 9123cbe50e4a3417dc4f205092a436d7230c7414
> src/tests/containerizer/memory_pressure_tests.cpp 488051dbf85a9d0baf5f61b8c0d28aa14dad9427
> src/tests/containerizer/ports_isolator_tests.cpp 0969cf545254c6cadfd69fa0f4f4f087f07af4b7
> src/tests/containerizer/xfs_quota_tests.cpp ce69c882251c36cf50dc1b46dd0b9337bb7b5043
> src/tests/disk_quota_tests.cpp db53108ebe3fb67b8a69a0e2925159f7b5965efb
> src/tests/fault_tolerance_tests.cpp 64a865339cc0dad1bc43aea40c6491d0ece6e48a
> src/tests/fetcher_cache_tests.cpp 4d9e5d83279ef706b1b91d1dcf4f13f59e276749
> src/tests/gc_tests.cpp bff3c0530441d378c8cebc4e5539d603bb1b8810
> src/tests/master_allocator_tests.cpp 43f1c7183fc1016e037af83dd6f4f1423a8c74c6
> src/tests/master_authorization_tests.cpp 8e526fc80062c56c91a62782d242de5dfed64e96
> src/tests/master_slave_reconciliation_tests.cpp 0541aa56a414fbec872e7e3ec6ad50206766054a
> src/tests/master_tests.cpp 8be43f332013d59493623eccf4e410d2f0bd6870
> src/tests/oversubscription_tests.cpp 41c1178ec4514ef6a1fb369734d4f9d73710d883
> src/tests/partition_tests.cpp a9036a1eb0bd0e803425caa373cce77b6e40aeb9
> src/tests/persistent_volume_tests.cpp 4cb2c95f2af059e827f10349f2dd29713d8b368c
> src/tests/slave_recovery_tests.cpp 5a3f19f601ef2e72cadca0426c4e9e5457836db8
> src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226
> src/tests/storage_local_resource_provider_tests.cpp c2fcbf32936ef1cb6fd313eac7e3c9c5de99c1fc
> src/tests/teardown_tests.cpp 392cacfaefb365cb299382488aca3f8c8e2c0392
> src/tests/upgrade_tests.cpp dd73d730bf8f0ae69ed5280a459e2c9534a54a49
>
>
> Diff: https://reviews.apache.org/r/65938/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 65938: Replaced "re-register" terminology with
"reregister".
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65938/#review198765
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65938]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 6, 2018, 11:52 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65938/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 11:52 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-6128
> https://issues.apache.org/jira/browse/MESOS-6128
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We sometimes use "re-register" in comments and elsewhere we
> use "reregister". We should pick the "reregister" form and
> use it consistently.
>
>
> Diffs
> -----
>
> CHANGELOG 20bfe210d1b9b027a3be0712fe71c560b177d061
> docs/agent-recovery.md 8df72cb3adfec9f52429b88c19c437c6fe3d5fd9
> docs/app-framework-development-guide.md e31bffc78daffa9f82ecf5361f91281354f9e466
> docs/configuration/agent.md 71e5a86cbed6cd646c398800889308bc2912083f
> docs/configuration/master.md 7b2bb98c43e7f419e6bbe28fdb0f3d1946557165
> docs/high-availability-framework-guide.md f2467735bfc4c47c21d108c50f74aea4d302e252
> docs/high-availability.md 1bad0ee6ddeebbf47dbc0c202c28cdec3000fb75
> docs/maintenance.md 88434e843279626ef89c61c3f70cc9da54b3eee8
> docs/monitoring.md 7ad15b4f821108083b5f9f4381c33d5f465d361b
> docs/operator-http-api.md 64110f03ad3158765f8b928a68d004e1f296d4c8
> docs/reconciliation.md 473e3e2ad08ae0154c3d84cd72de076a3922638e
> docs/roles.md ddea114baed0e378b43fd7a9462787cf0689216c
> docs/task-state-reasons.md 5f7f8d2eeb91d47c44bdf665fe31eb474933c2de
> include/mesos/authorizer/acls.proto 086274388ace3a60c68cca1a37507af3ec429bf8
> include/mesos/executor.hpp 68cba9e3c411eb9f396b49adcc9d71137a5d948c
> include/mesos/master/master.proto f40caa2a6338ff58a325444cfb72cd24f2c99472
> include/mesos/mesos.proto 2c5ae4cd8d9cfaabd42a9e94ce94cd73bfacc6eb
> include/mesos/scheduler.hpp 423235a90166e71866a88baa3bf16ba551010c5c
> include/mesos/scheduler/scheduler.proto 7a90355c3d1a362ebb4fdb63bfe1fba8aca60d5b
> include/mesos/v1/master/master.proto 67c9560eaa7bd6b20b73af07f7666f0d98c4453d
> include/mesos/v1/mesos.proto 67080ed2907a2fee53dab4802dce0aeac3424412
> site/source/blog/2013-10-23-slave-recovery-in-apache-mesos.md 5b604f591d20b08cf4329f7503eaa4d137e5ed85
> site/source/blog/2014-06-12-mesos-0-19-0-released.md 2d2a3db21580422761cd1895b5aab5c894c7e72f
> site/source/blog/2017-09-18-mesos-1-4-0-released.md fcdc2e426ef95e4ee90f6a637ac083aa6d0f2cf7
> site/source/blog/2017-12-07-performance-working-group-progress-report.md b7f5a8786953f54b63704e09c23528003052f695
> src/exec/exec.cpp 0c76a3f1d05b3ff93b04a2bf4ac6a9f433dd1d19
> src/java/src/org/apache/mesos/Executor.java 078c0c7ea3ad68e9b4b40802c3d6b94084cbb69b
> src/java/src/org/apache/mesos/Scheduler.java cb5a65872fa4bbd711c86af258e58aa7b33777b8
> src/master/allocator/mesos/hierarchical.cpp e0ab8360c282092b141a12e8628f3d08039a0b69
> src/master/constants.hpp 17092ea1b43a3fa86fbbcb4dff6b24922054ae12
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb
> src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35
> src/python/executor/src/mesos/executor/proxy_executor.cpp 2462ccb3be1f7e0078448bfe0e1dc577c859422f
> src/python/interface/src/mesos/interface/__init__.py 048eb6438d204aa20d71a8d59f516f06934f2d99
> src/sched/sched.cpp 81aa0d7d34753be2bac49753be1ab3be21746d5d
> src/slave/constants.hpp b79c084f4952affec531f29797479f3e702a66b6
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp f1d377eb911fb6a0ca3a4749a0e00d5166f35129
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp df240bcff9e53faab275ac41ba3221789467dca6
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/slave.hpp f161369732932ec99abbf635f91c88425744b3a9
> src/slave/slave.cpp 8cb6899bf15fb697c3cb2784f63b7c2d5729d219
> src/slave/task_status_update_manager.cpp 24d803d5ba0dab5c0ca5316cf2affedba3a6e65e
> src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c
> src/tests/authentication_tests.cpp 3c6124f641b64cb6f67cb1605958e12151b91456
> src/tests/containerizer/docker_containerizer_tests.cpp 85e6f8739dd2d6f9119e30f13f681cf4b8dc45ed
> src/tests/containerizer/docker_volume_isolator_tests.cpp 9123cbe50e4a3417dc4f205092a436d7230c7414
> src/tests/containerizer/memory_pressure_tests.cpp 488051dbf85a9d0baf5f61b8c0d28aa14dad9427
> src/tests/containerizer/ports_isolator_tests.cpp 0969cf545254c6cadfd69fa0f4f4f087f07af4b7
> src/tests/containerizer/xfs_quota_tests.cpp ce69c882251c36cf50dc1b46dd0b9337bb7b5043
> src/tests/disk_quota_tests.cpp db53108ebe3fb67b8a69a0e2925159f7b5965efb
> src/tests/fault_tolerance_tests.cpp 64a865339cc0dad1bc43aea40c6491d0ece6e48a
> src/tests/fetcher_cache_tests.cpp 4d9e5d83279ef706b1b91d1dcf4f13f59e276749
> src/tests/gc_tests.cpp bff3c0530441d378c8cebc4e5539d603bb1b8810
> src/tests/master_allocator_tests.cpp 43f1c7183fc1016e037af83dd6f4f1423a8c74c6
> src/tests/master_authorization_tests.cpp 8e526fc80062c56c91a62782d242de5dfed64e96
> src/tests/master_slave_reconciliation_tests.cpp 0541aa56a414fbec872e7e3ec6ad50206766054a
> src/tests/master_tests.cpp 8be43f332013d59493623eccf4e410d2f0bd6870
> src/tests/oversubscription_tests.cpp 41c1178ec4514ef6a1fb369734d4f9d73710d883
> src/tests/partition_tests.cpp a9036a1eb0bd0e803425caa373cce77b6e40aeb9
> src/tests/persistent_volume_tests.cpp 4cb2c95f2af059e827f10349f2dd29713d8b368c
> src/tests/slave_recovery_tests.cpp 5a3f19f601ef2e72cadca0426c4e9e5457836db8
> src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226
> src/tests/storage_local_resource_provider_tests.cpp c2fcbf32936ef1cb6fd313eac7e3c9c5de99c1fc
> src/tests/teardown_tests.cpp 392cacfaefb365cb299382488aca3f8c8e2c0392
> src/tests/upgrade_tests.cpp dd73d730bf8f0ae69ed5280a459e2c9534a54a49
>
>
> Diff: https://reviews.apache.org/r/65938/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27).
>
>
> Thanks,
>
> James Peach
>
>