You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/09 09:10:21 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request
#3915: Parser1
tristaZero opened a new pull request #3915: Parser1
URL: https://github.com/apache/incubator-shardingsphere/pull/3915
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3915: Add
interface for antlr visitors
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #3915: Add interface for antlr visitors
URL: https://github.com/apache/incubator-shardingsphere/pull/3915
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull
request #3915: Parser1
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #3915: Parser1
URL: https://github.com/apache/incubator-shardingsphere/pull/3915#discussion_r364700488
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/pom.xml
##########
@@ -49,8 +49,8 @@
<id>antlr</id>
<configuration>
<libDirectory>src/main/antlr4/imports/mysql/</libDirectory>
- <listener>false</listener>
- <visitor>false</visitor>
+ <listener>true</listener>
Review comment:
Listeners are used for checking later and not necessary now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #3915: Parser1
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #3915: Parser1
URL: https://github.com/apache/incubator-shardingsphere/pull/3915#discussion_r364647387
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/pom.xml
##########
@@ -49,8 +49,8 @@
<id>antlr</id>
<configuration>
<libDirectory>src/main/antlr4/imports/mysql/</libDirectory>
- <listener>false</listener>
- <visitor>false</visitor>
+ <listener>true</listener>
Review comment:
Do we need generate listener too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services