[GitHub] bondolo commented on issue #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting

[GitBox <gi...@apache.org>]

bondolo commented on issue #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting
URL: https://github.com/apache/incubator-netbeans/pull/173#issuecomment-373874726
 
 
   I believe the requested tests are more important. I haven't had time to turn the presented examples from this thread into tests (or more importantly how to turn them in to appropriate NetBeans tests).
   
   I am still somewhat resistant to adding an option. In the current proposed patch the effect is for the source reformatter to **not**  insert extra braces that the user did not enter when performing reformatting, ie. the reformatter makes fewer changes to user code. If the user did include braces then they are preserved.
   
   If user enables the existing remove braces option then reformatting will remove the "extra" braces around some try/synchronized statements, however since it also removes them from conditionals with single statement bodies it is probably not a widely used option and those who use it must really hate braces.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists