[jira] [Commented] (TAP5-2158) Client-side validation of @Size is not working when only min or max is set

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811199#comment-13811199 ] 

ASF subversion and git services commented on TAP5-2158:
-------------------------------------------------------

Commit a073dc01c55a8316c63096a89a7424066128b821 in branch refs/heads/master from [~thiagohp]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=a073dc0 ]

TAP5-2158: Client-side validation of @Size is not working when only min
or max is set. Actually, it was already fixed, probably by some change
to Element.attribute() in JavaScript, so I just added some tests
covering this ticket.

> Client-side validation of @Size is not working when only min or max is set
> --------------------------------------------------------------------------
>
>                 Key: TAP5-2158
>                 URL: https://issues.apache.org/jira/browse/TAP5-2158
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-beanvalidator
>    Affects Versions: 5.4
>            Reporter: Balázs Palcsó
>            Assignee: Thiago H. de Paula Figueiredo
>            Priority: Minor
>
> Exact version: 5.4-alpha-14
> Server side example:
> {code}
> @Size(min = 3)
> private String name;
> {code}
> On the client side the following function gets executed:
> {code}
> doRangeValidate = function(element, value, memo) {
>       var max, min;
>       min = rangeValue(element, "data-range-min", 0);
>       max = rangeValue(element, "data-range-max", Number.MAX_VALUE);
>       if (_.isString(value)) {
>         value = value.length;
>       }
>       if (!((min <= value && value <= max))) {
>         memo.error = (element.attribute("data-range-message")) || "RANGE ERROR";
>         return false;
>       }
>       return true;
>     };
> {code}
> In the above example max is evaluated to NaN and therefore the function returns false causing validation error.
> Same applies when you only max is specified in @Size annotation and min is evaluated to NaN.
> h3. Workaround 
> Specify both min and max.



--
This message was sent by Atlassian JIRA
(v6.1#6144)