You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2022/04/25 18:18:18 UTC

[GitHub] [parquet-mr] theosib-amazon commented on pull request #953: Performance optimizations: Merged all LittleEndianDataInputStream functionality into ByteBufferInputStream

theosib-amazon commented on PR #953:
URL: https://github.com/apache/parquet-mr/pull/953#issuecomment-1108891240

   I made all the cosmetic changes you asked for.
   
   I'm not sure why you're asking to separate the ByteBufferInputStream additions into its own PR, since the PR was all about improving performance by moving functionality from LittleEndianDataInputStream into ByteBufferInputStream. The changes to PlainValuesReader rely on all of those changes.
   
   The only reason I kept the reference to LittleEndianDataInputStream in PlainValuesReader is because otherwise the build fails with a compatibility break against 1.12.0. I'm going to go ahead with the change in the hopes that that doesn't cause a check failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org