You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by la...@apache.org on 2022/04/25 06:17:35 UTC

[kudu] 01/03: [disk_failure-itest] fix premature return from AllowRecovery()

This is an automated email from the ASF dual-hosted git repository.

laiyingchun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 88148d37ab2ecb3ffc512cc756f4baf7d502bb5f
Author: shenxingwuying <sh...@gmail.com>
AuthorDate: Wed Apr 20 16:33:09 2022 +0800

    [disk_failure-itest] fix premature return from AllowRecovery()
    
    Fixed a premature return from the AllowRecovery() utility function.
    Prior to this fix, the error injection flags
    were reset only for the first tserver upon call
    to AllowRecovery().
    
    Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113
    Reviewed-on: http://gerrit.cloudera.org:8080/18429
    Reviewed-by: Yifan Zhang <ch...@163.com>
    Tested-by: Yifan Zhang <ch...@163.com>
---
 src/kudu/integration-tests/disk_failure-itest.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kudu/integration-tests/disk_failure-itest.cc b/src/kudu/integration-tests/disk_failure-itest.cc
index ec84c063b..7b0544f1e 100644
--- a/src/kudu/integration-tests/disk_failure-itest.cc
+++ b/src/kudu/integration-tests/disk_failure-itest.cc
@@ -278,7 +278,7 @@ class TabletServerDiskErrorITest : public DiskErrorITestBase {
         // Then allow for recovery.
         { "enable_tablet_copy", "true" },
       };
-      return SetFlags(cluster_->tablet_server(i), recovery_flags);
+      RETURN_NOT_OK(SetFlags(cluster_->tablet_server(i), recovery_flags));
     }
     return Status::OK();
   }