[GitHub] [spark] mridulm commented on a change in pull request #34834: [SPARK-37580][CORE] TaskSet abort due to the task failed times reach the max threshold should check if another attempt is succeeded

[GitBox <gi...@apache.org>]

mridulm commented on a change in pull request #34834:
URL: https://github.com/apache/spark/pull/34834#discussion_r766154512



##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -954,7 +954,7 @@ private[spark] class TaskSetManager(
       taskSetExcludelistHelperOpt.foreach(_.updateExcludedForFailedTask(
         info.host, info.executorId, index, failureReason))
       numFailures(index) += 1
-      if (numFailures(index) >= maxTaskFailures) {
+      if (numFailures(index) >= maxTaskFailures && !successful(index)) {

Review comment:
       Thoughts on moving this check to the outside `if` condition ?
   Effectively treating a speculative task failure as `countTowardsTaskFailures` = `false`
   +CC @Ngone51 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org