You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/29 08:49:16 UTC
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #255: [FLINK-28727] Flink Source supports `SupportsLimitPushDown`
JingsongLi commented on code in PR #255:
URL: https://github.com/apache/flink-table-store/pull/255#discussion_r933011387
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSourceReader.java:
##########
@@ -35,9 +35,10 @@
FileStoreSourceSplit,
FileStoreSourceSplitState> {
- public FileStoreSourceReader(SourceReaderContext readerContext, TableRead tableRead) {
+ public FileStoreSourceReader(
+ SourceReaderContext readerContext, TableRead tableRead, Long limit) {
Review Comment:
`@Nullable`
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSourceSplitReader.java:
##########
@@ -52,11 +54,12 @@
private long currentNumRead;
private RecordReader.RecordIterator<RowData> currentFirstBatch;
- public FileStoreSourceSplitReader(TableRead tableRead) {
+ public FileStoreSourceSplitReader(TableRead tableRead, Long limit) {
Review Comment:
`@Nullable`
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSourceSplitReader.java:
##########
@@ -52,11 +54,12 @@
private long currentNumRead;
private RecordReader.RecordIterator<RowData> currentFirstBatch;
- public FileStoreSourceSplitReader(TableRead tableRead) {
+ public FileStoreSourceSplitReader(TableRead tableRead, Long limit) {
this.tableRead = tableRead;
+ this.limit = limit;
this.splits = new LinkedList<>();
this.pool = new Pool<>(1);
- this.pool.add(new FileStoreRecordIterator());
+ this.pool.add(new FileStoreRecordIterator(limit));
Review Comment:
`FileStoreRecordIterator` is an inner class, it can just read `limit` field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org