[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1061: JAMES-3771 Migrate opensearch high level rest client to new java client

[GitBox <gi...@apache.org>]

quantranhong1999 commented on code in PR #1061:
URL: https://github.com/apache/james-project/pull/1061#discussion_r1049353638


##########
mailbox/opensearch/src/main/java/org/apache/james/mailbox/opensearch/events/OpenSearchListeningMessageSearchIndex.java:
##########
@@ -273,8 +272,11 @@ private ArrayNode extractUserFlags(ObjectNode source) {
     private void extractMessageIdFromHit(Hit<ObjectNode> hit, SynchronousSink<MessageId> sink) {
         JsonData messageId = hit.fields().get(MESSAGE_ID);
         if (messageId != null) {
-            List<String> extractMessageId = messageId.deserialize(JsonpDeserializer.arrayDeserializer(JsonpDeserializer.stringDeserializer()));
-            sink.next(messageIdFactory.fromString(extractMessageId.get(0)));

Review Comment:
   Q: How did you diagnose that `JsonpDeserializer.arrayDeserializer seems to do some blocking action in its code...`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org