You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Krzysztof Koziol (JIRA)" <ji...@apache.org> on 2010/12/24 09:38:46 UTC
[jira] Created: (WW-3549) Shade common-io from the xwork-core.jar
Shade common-io from the xwork-core.jar
---------------------------------------
Key: WW-3549
URL: https://issues.apache.org/jira/browse/WW-3549
Project: Struts 2
Issue Type: Bug
Components: Build Management
Affects Versions: 2.2.1.1
Environment: struts.version=2.2.1.1
Reporter: Krzysztof Koziol
Priority: Critical
Fix For: 2.2.2
I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988435#action_12988435 ]
Maurizio Cucchiara commented on WW-3549:
----------------------------------------
Because of a misconfiguration of the maven shade plugin, FileUtils.class went under the org.apache.commons.io package.
Now it goes under org.apache.commons.io xwork package.
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Krzysztof Koziol (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975070#action_12975070 ]
Krzysztof Koziol commented on WW-3549:
--------------------------------------
The issue is that FileUtils from the common-io was not properly shaded and was included in the xwork-core.jar
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart reassigned WW-3549:
---------------------------------
Assignee: Lukasz Lenart
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Krzysztof Koziol (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001913#comment-13001913 ]
Krzysztof Koziol commented on WW-3549:
--------------------------------------
Any update on when 2.2.2 will be released?
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001916#comment-13001916 ]
Lukasz Lenart commented on WW-3549:
-----------------------------------
Soon, few more bugs are waiting ...
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988506#action_12988506 ]
Maurizio Cucchiara commented on WW-3549:
----------------------------------------
Unfortunately xwork core doesn't depend only on FileUtils class.
So there are 2 alternatives:
1. shade the entire common-io library
2. unshade FileUtils class (the struts-core itself already depends on common-io library)
I prefer the second option, see comments.
I'm going to restore the previous version.
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974905#action_12974905 ]
Dave Newton commented on WW-3549:
---------------------------------
(Did something happen with shading? I've not had this issue with any of the shaded jars.)
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Falko Modler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988066#action_12988066 ]
Falko Modler commented on WW-3549:
----------------------------------
This problem has become even worse now that commons-io 2.0 has been released!
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975099#action_12975099 ]
Lukasz Lenart commented on WW-3549:
-----------------------------------
The plan is to get rid of shading in the next major release.
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975109#action_12975109 ]
Maurizio Cucchiara commented on WW-3549:
----------------------------------------
Lukasz,
my guess is that Krzysztof would like to /shade/ common-io package, such that he might get rid of common-io-1.3.2.jar dependency in favor of 1.4 version (notice that the pom of trunk is already using the 1.4 version).
So, the points are:
1. the next struts2's release will use the 1.4 verison of common-io (according to pom.xml of xwork module)
2. getting rid of shading plugin, although it has undoubtedly benefits (like making intellij idea work), has cons too (the dependencies clashes are some of them)
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988493#action_12988493 ]
Maurizio Cucchiara commented on WW-3549:
----------------------------------------
Done.
You can download the latest version of struts from here [1] or latest xwork version [2].
Could you confirm if it works now?
[1] https://hudson.apache.org/hudson/job/Struts2/lastBuild/org.apache.struts$struts2-assembly/
[2] https://hudson.apache.org/hudson/job/Struts2/lastBuild/org.apache.struts.xwork$xwork-core/artifact/org.apache.struts.xwork/xwork-core/2.2.2-SNAPSHOT/xwork-core-2.2.2-SNAPSHOT.jar
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart resolved WW-3549.
-------------------------------
Resolution: Fixed
Removed shading from the project. Please check the latest snapshot (should be ready in few hours)
https://hudson.apache.org/hudson/job/Struts2/lastStableBuild/org.apache.struts$struts2-assembly/
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (WW-3549) Shade common-io from the
xwork-core.jar
Posted by "Falko Modler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988066#action_12988066 ]
Falko Modler edited comment on WW-3549 at 1/28/11 8:07 AM:
-----------------------------------------------------------
This problem has become even worse now that commons-io 2.0 has been released!
You should really get rid of this inclusion (regardless of the version).
was (Author: famod):
This problem has become even worse now that commons-io 2.0 has been released!
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001388#comment-13001388 ]
Lukasz Lenart commented on WW-3549:
-----------------------------------
Ok, I will remove the shading at all
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Krzysztof Koziol (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988698#comment-12988698 ]
Krzysztof Koziol commented on WW-3549:
--------------------------------------
Hi Maurizio,
I think that the 2nd option will be fine.
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Krzysztof Koziol (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979541#action_12979541 ]
Krzysztof Koziol commented on WW-3549:
--------------------------------------
Maurizio, I agree with your comment. Thanks.
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3549) Shade common-io from the xwork-core.jar
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988068#action_12988068 ]
Dave Newton commented on WW-3549:
---------------------------------
Patches welcome.
> Shade common-io from the xwork-core.jar
> ---------------------------------------
>
> Key: WW-3549
> URL: https://issues.apache.org/jira/browse/WW-3549
> Project: Struts 2
> Issue Type: Bug
> Components: Build Management
> Affects Versions: 2.2.1.1
> Environment: struts.version=2.2.1.1
> Reporter: Krzysztof Koziol
> Assignee: Lukasz Lenart
> Priority: Critical
> Fix For: 2.2.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I would kindly request to remove common-io package from the xwork-core.jar. I'm using maven and I can not utilize the FileUtils class that was shipped in the latest common-io jar only because the same class exists in the xwork-core.jar.
> Merry Christmas!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.