You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by jj...@apache.org on 2014/11/13 00:55:32 UTC
kafka git commit: KAFKA-1762;
Update max-inflight-requests doc-string in producer config to note
risk of reordering in the presence of retries
Repository: kafka
Updated Branches:
refs/heads/trunk 53160bb07 -> 2cd9ae745
KAFKA-1762; Update max-inflight-requests doc-string in producer config to note risk of reordering in the presence of retries
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/2cd9ae74
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/2cd9ae74
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/2cd9ae74
Branch: refs/heads/trunk
Commit: 2cd9ae74544efe049393e1a6bf60533aea956d7d
Parents: 53160bb
Author: Guozhang Wang <gu...@linkedin.com>
Authored: Wed Nov 12 15:54:50 2014 -0800
Committer: Joel Koshy <jj...@gmail.com>
Committed: Wed Nov 12 15:55:03 2014 -0800
----------------------------------------------------------------------
.../java/org/apache/kafka/clients/producer/ProducerConfig.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/2cd9ae74/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
index 9095caf..72d3ddd 100644
--- a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
+++ b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
@@ -171,7 +171,9 @@ public class ProducerConfig extends AbstractConfig {
/** <code>max.in.flight.requests.per.connection</code> */
public static final String MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION = "max.in.flight.requests.per.connection";
- private static final String MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION_DOC = "The maximum number of unacknowledged requests the client will send on a single connection before blocking.";
+ private static final String MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION_DOC = "The maximum number of unacknowledged requests the client will send on a single connection before blocking."
+ + " Note that if this setting is set to be greater than 1 and there are failed sends, there is a risk of"
+ + " message re-ordering due to retries (i.e., if retries are enabled).";
static {
config = new ConfigDef().define(BOOTSTRAP_SERVERS_CONFIG, Type.LIST, Importance.HIGH, BOOSTRAP_SERVERS_DOC)