You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/19 09:05:44 UTC
[GitHub] [apisix-ingress-controller] AlinsRan opened a new pull request, #1170: Refactor/annotation
AlinsRan opened a new pull request, #1170:
URL: https://github.com/apache/apisix-ingress-controller/pull/1170
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1170: refactor: annotations
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1170:
URL: https://github.com/apache/apisix-ingress-controller/pull/1170#issuecomment-1198901301
we have enterd v1.5 release window, I will put this one to v1.6, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1170: Refactor: annotation
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1170:
URL: https://github.com/apache/apisix-ingress-controller/pull/1170#issuecomment-1188846389
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1170](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71fc302) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/628abb945f7bc515bd5fcccf1479443305236478?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (628abb9) will **decrease** coverage by `0.10%`.
> The diff coverage is `55.42%`.
> :exclamation: Current head 71fc302 differs from pull request most recent head c85158f. Consider uploading reports for the commit c85158f to get more accurate results
```diff
@@ Coverage Diff @@
## master #1170 +/- ##
==========================================
- Coverage 30.45% 30.34% -0.11%
==========================================
Files 81 81
Lines 9839 9833 -6
==========================================
- Hits 2996 2984 -12
- Misses 6517 6522 +5
- Partials 326 327 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...kg/kube/translation/annotations/plugins/plugins.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcGx1Z2lucy9wbHVnaW5zLmdv) | `0.00% <0.00%> (ø)` | |
| [...g/kube/translation/annotations/plugins/redirect.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcGx1Z2lucy9yZWRpcmVjdC5nbw==) | `12.50% <20.00%> (ø)` | |
| [...kg/kube/translation/annotations/plugins/rewrite.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcGx1Z2lucy9yZXdyaXRlLmdv) | `11.11% <20.00%> (ø)` | |
| [pkg/kube/translation/annotations/plugins/csrf.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcGx1Z2lucy9jc3JmLmdv) | `16.66% <25.00%> (ø)` | |
| [...e/translation/annotations/plugins/authorization.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcGx1Z2lucy9hdXRob3JpemF0aW9uLmdv) | `22.22% <33.33%> (ø)` | |
| [pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=) | `58.82% <72.72%> (-2.72%)` | :arrow_down: |
| [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `59.43% <76.19%> (-1.48%)` | :arrow_down: |
| [pkg/kube/translation/annotations/plugins/cors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcGx1Z2lucy9jb3JzLmdv) | `100.00% <100.00%> (ø)` | |
| [...be/translation/annotations/plugins/forward\_auth.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcGx1Z2lucy9mb3J3YXJkX2F1dGguZ28=) | `100.00% <100.00%> (ø)` | |
| [...e/translation/annotations/plugins/iprestriction.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcGx1Z2lucy9pcHJlc3RyaWN0aW9uLmdv) | `100.00% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [628abb9...c85158f](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] AlinsRan closed pull request #1170: refactor: annotations
Posted by GitBox <gi...@apache.org>.
AlinsRan closed pull request #1170: refactor: annotations
URL: https://github.com/apache/apisix-ingress-controller/pull/1170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1170: refactor: annotations
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1170:
URL: https://github.com/apache/apisix-ingress-controller/pull/1170#issuecomment-1211098235
need to resolve conflicts. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org