You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ajantha-bhat <gi...@git.apache.org> on 2018/10/10 11:26:50 UTC
[GitHub] carbondata pull request #2809: [HOTFIX] Fix SDV test case failure after PR #...
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2809
[HOTFIX] Fix SDV test case failure after PR #2645
**Changes:
1) #2645 has blocked the schema for external table. But SDV test cases were not updated. Hence updated the test cases
2) table properties was not blocked for external table, so even when a valid table property is passed, validation used of table properties is used to fail as for external table, fields (schema) will be null.
Hence blocked this with proper error message**
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed? NA
- [ ] Any backward compatibility impacted? NA
- [ ] Document update required? NA
- [ ] Testing done
yes, SDV test case is modified and locally ran
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajantha-bhat/carbondata sdk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2809.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2809
----
commit 0cb34dd22810452cc3ee35f6d0d6005dc1c432a1
Author: ajantha-bhat <aj...@...>
Date: 2018-10-10T11:21:12Z
fix SDV test case failure after PR #2645
----
---
[GitHub] carbondata issue #2809: [HOTFIX] Fix SDV test case failure after PR #2645
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2809
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/773/
---
[GitHub] carbondata issue #2809: [HOTFIX] Fix SDV test case failure after PR #2645
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2809
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/970/
---
[GitHub] carbondata issue #2809: [HOTFIX] Fix SDV test case failure after PR #2645
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2809
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1119/
---
[GitHub] carbondata issue #2809: [HOTFIX] Fix SDV test case failure after PR #2645
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2809
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9038/
---
[GitHub] carbondata issue #2809: [HOTFIX] Fix SDV test case failure after PR #2645
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2809
LGTM
---
[GitHub] carbondata pull request #2809: [HOTFIX] Fix SDV test case failure after PR #...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2809
---
[GitHub] carbondata issue #2809: [HOTFIX] Fix SDV test case failure after PR #2645
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2809
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/919/
---
[GitHub] carbondata issue #2809: [HOTFIX] Fix SDV test case failure after PR #2645
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2809
@ravipesala , @jackylk : please check
---
[GitHub] carbondata issue #2809: [HOTFIX] Fix SDV test case failure after PR #2645
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2809
LGTM
---