[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14405: [MXNet-1343][Fit API]Add CNN integration test for fit() API

[GitBox <gi...@apache.org>]

roywei commented on a change in pull request #14405: [MXNet-1343][Fit API]Add CNN integration test for fit() API
URL: https://github.com/apache/incubator-mxnet/pull/14405#discussion_r270097484
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -1296,6 +1296,20 @@ nightly_scala_demo_test_cpu() {
     bash bin/run_im.sh
 }
 
+nightly_estimator_cnn_gpu() {
+    set -ex
+    cd /work/mxnet/tests/nightly/estimator
+    export PYTHONPATH=/work/mxnet/python/
+    python test_estimator_cnn.py --type gpu
 
 Review comment:
   what's the reason to run a python script instead of using nosetest and assert accuracy at the end?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services