[GitHub] [incubator-superset] riahk commented on a change in pull request #11370: fix: add sort option to filters, sort chart list filter options

[GitBox <gi...@apache.org>]

riahk commented on a change in pull request #11370:
URL: https://github.com/apache/incubator-superset/pull/11370#discussion_r509754761



##########
File path: superset-frontend/src/components/ListView/Filters.tsx
##########
@@ -119,6 +121,25 @@ function SelectFilter({
         setSelectedOption(matchingOption);
       }
     }
+
+    // Check whether list should be sorted (alphanumerically, ascending)
+    if (sort) {

Review comment:
       Updated! I added a default `order_column` for the generic related/distinct sorts, although `datasets` actually has its own custom fetch method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org