You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/07 19:57:48 UTC

[GitHub] [airflow] uranusjr commented on pull request #15232: S3Hook.load_file should accept Path object in addition to str

uranusjr commented on pull request #15232:
URL: https://github.com/apache/airflow/pull/15232#issuecomment-815193220


   No, I meant the latter. `Path` is for actual paths in the local filesystem, and shouldn’t be used to represent a path on S3. That should use `PurePosixPath`, which is basically a wrapper to a list of path components that will be joined with `/` when stringified. Your current implementation is the opposite of what I had in mind; since `filename` here should point to a local file, it should use `Path`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org