You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/02/23 00:57:01 UTC
Review Request 31288: Fixed bug in tests from 'internal' revert.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31288/
-----------------------------------------------------------
Review request for mesos, Kapil Arya and Niklas Nielsen.
Repository: mesos
Description
-------
I'm not sure how the tests were ever passing?
Diffs
-----
src/tests/rate_limiting_tests.cpp 784ac76ee81918466de44196f5adc2b88adfee96
Diff: https://reviews.apache.org/r/31288/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 31288: Fixed bug in tests from 'internal' revert.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31288/#review73480
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 22, 2015, 3:57 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31288/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2015, 3:57 p.m.)
>
>
> Review request for mesos, Kapil Arya and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> I'm not sure how the tests were ever passing?
>
>
> Diffs
> -----
>
> src/tests/rate_limiting_tests.cpp 784ac76ee81918466de44196f5adc2b88adfee96
>
> Diff: https://reviews.apache.org/r/31288/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 31288: Fixed bug in tests from 'internal' revert.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31288/#review73471
-----------------------------------------------------------
Bad patch!
Reviews applied: [31236]
Failed command: ./support/apply-review.sh -n -r 31236
Error:
2015-02-23 00:13:49 URL:https://reviews.apache.org/r/31236/diff/raw/ [195807/195807] -> "31236.patch" [1]
error: patch failed: src/sched/sched.cpp:117
error: src/sched/sched.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Feb. 22, 2015, 11:57 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31288/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2015, 11:57 p.m.)
>
>
> Review request for mesos, Kapil Arya and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> I'm not sure how the tests were ever passing?
>
>
> Diffs
> -----
>
> src/tests/rate_limiting_tests.cpp 784ac76ee81918466de44196f5adc2b88adfee96
>
> Diff: https://reviews.apache.org/r/31288/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 31288: Fixed bug in tests from 'internal' revert.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31288/#review73473
-----------------------------------------------------------
Ship it!
I know why. The RateLimitingTests are flaky on my machine and so when I saw the failure, I ignored it. Sorry about that.
- Kapil Arya
On Feb. 22, 2015, 6:57 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31288/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2015, 6:57 p.m.)
>
>
> Review request for mesos, Kapil Arya and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> I'm not sure how the tests were ever passing?
>
>
> Diffs
> -----
>
> src/tests/rate_limiting_tests.cpp 784ac76ee81918466de44196f5adc2b88adfee96
>
> Diff: https://reviews.apache.org/r/31288/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 31288: Fixed bug in tests from 'internal' revert.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31288/
-----------------------------------------------------------
(Updated Feb. 22, 2015, 11:57 p.m.)
Review request for mesos, Kapil Arya and Niklas Nielsen.
Repository: mesos
Description
-------
I'm not sure how the tests were ever passing?
Diffs
-----
src/tests/rate_limiting_tests.cpp 784ac76ee81918466de44196f5adc2b88adfee96
Diff: https://reviews.apache.org/r/31288/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman