You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Collins-Sussman <su...@collab.net> on 2002/05/29 14:17:04 UTC
Re: svn commit: rev 2030 - branches/issue-654-dev/subversion/svnadmin branches/issue-654-dev/subversion/include branches/issue-654-dev/subversion/libsvn_subr branches/issue-654-dev/subversion/libsvn_repos
cmpilato@tigris.org writes:
> Author: cmpilato
> Date: 2002-05-29 14:00 GMT
> New Revision: 2030
>
> Log:
> Merging in a bunch of changes originally committed to /trunk by
> sussman regardine the filesystem dump/load (give or take a little
> fix-em-up code to make it work on the branch).
Keep your eyes open, cmpilato -- I'm going to commit some fixes to the
dumpstream parser later this morning.
(I discovered a really silly bug while dreaming about svn last night.
I woke up, tried out my test-case, and indeed the bug was there. :-) )
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 2030 - branches/issue-654-dev/subversion/svnadmin branches/issue-654-dev/subversion/include branches/issue-654-dev/subversion/libsvn_subr branches/issue-654-dev/subversion/libsvn_repos
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Wed, May 29, 2002 at 10:04:18AM -0500, Ben Collins-Sussman wrote:
> cmpilato@collab.net writes:
>
> > > (I discovered a really silly bug while dreaming about svn last night.
> > > I woke up, tried out my test-case, and indeed the bug was there.
> > > :-) )
> >
> > Um...dude?
>
> No need for panic.
i don't think he was panicing about whatever the bug is, it's more
that you're dreaming about subversion bugs ;-)
-garrett
--
garrett rooney Remember, any design flaw you're
rooneg@electricjellyfish.net sufficiently snide about becomes
http://electricjellyfish.net/ a feature. -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 2030 - branches/issue-654-dev/subversion/svnadmin branches/issue-654-dev/subversion/include branches/issue-654-dev/subversion/libsvn_subr branches/issue-654-dev/subversion/libsvn_repos
Posted by cm...@collab.net.
Ben Collins-Sussman <su...@collab.net> writes:
> cmpilato@collab.net writes:
>
> > > (I discovered a really silly bug while dreaming about svn last night.
> > > I woke up, tried out my test-case, and indeed the bug was there.
> > > :-) )
> >
> > Um...dude?
>
> No need for panic.
>
> The parser has two modes: require copy sources to exist, or not.
>
> If a node in the dumpfile says it has copy history, then the parser
> calls svn_fs_copy() when the flag is set, and screams and chokes if
> the copy source isn't available. If the flag isn't set, that's
> fine... instead of attempting to make a copy, it just adds the whole
> file or subtree as "new" items. (Items in the dumpfile are always
> present as fulltexts). No big deal, you just lose the copy history,
> not the data.
>
> The bug is this: after successfully copying a subtree, it continues
> to parse the dumpfile, and sees nodes within the subtree, all marked
> as "things to add". Obviously, it should *skip* these items if the
> initial copy was successful. Right now, it tries to re-add them and
> the fs rightly errors out.
>
> 'Twill be fixed in a jif.
Heh. I wasn't questioning the sanity of your test case. I was
questioning the sanity of YOU.
As a former dreamer of Subversion myself (remember the skels jungle
gym?), I have to warn you. At first, yeah, it all seems like fun and
games, and you think, "Hey, this is the life!" and that as long as
nobody does anything "weird" it will all work out.
But it won't work out.
It never does.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 2030 - branches/issue-654-dev/subversion/svnadmin branches/issue-654-dev/subversion/include branches/issue-654-dev/subversion/libsvn_subr branches/issue-654-dev/subversion/libsvn_repos
Posted by Ben Collins-Sussman <su...@collab.net>.
cmpilato@collab.net writes:
> > (I discovered a really silly bug while dreaming about svn last night.
> > I woke up, tried out my test-case, and indeed the bug was there.
> > :-) )
>
> Um...dude?
No need for panic.
The parser has two modes: require copy sources to exist, or not.
If a node in the dumpfile says it has copy history, then the parser
calls svn_fs_copy() when the flag is set, and screams and chokes if
the copy source isn't available. If the flag isn't set, that's
fine... instead of attempting to make a copy, it just adds the whole
file or subtree as "new" items. (Items in the dumpfile are always
present as fulltexts). No big deal, you just lose the copy history,
not the data.
The bug is this: after successfully copying a subtree, it continues
to parse the dumpfile, and sees nodes within the subtree, all marked
as "things to add". Obviously, it should *skip* these items if the
initial copy was successful. Right now, it tries to re-add them and
the fs rightly errors out.
'Twill be fixed in a jif.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 2030 - branches/issue-654-dev/subversion/svnadmin branches/issue-654-dev/subversion/include branches/issue-654-dev/subversion/libsvn_subr branches/issue-654-dev/subversion/libsvn_repos
Posted by cm...@collab.net.
Ben Collins-Sussman <su...@collab.net> writes:
> cmpilato@tigris.org writes:
>
> > Author: cmpilato
> > Date: 2002-05-29 14:00 GMT
> > New Revision: 2030
> >
> > Log:
> > Merging in a bunch of changes originally committed to /trunk by
> > sussman regardine the filesystem dump/load (give or take a little
> > fix-em-up code to make it work on the branch).
>
> Keep your eyes open, cmpilato -- I'm going to commit some fixes to the
> dumpstream parser later this morning.
Cool. Thanks for the warning.
> (I discovered a really silly bug while dreaming about svn last night.
> I woke up, tried out my test-case, and indeed the bug was there.
> :-) )
Um...dude?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org