cvs commit: modperl/src/modules/perl mod_perl.c

[as...@hyperreal.org]

ask         98/10/15 01:44:46

  Modified:    .        Changes
               src/modules/perl mod_perl.c
  Log:
  "When building Apache 1.3.3 with Ben-SSL 1.27 and mod_perl 1.16 on
  Linux, I found that httpsd was segfaulting when trying to exec the
  gcache, because while running cleanups in preparation for an exec, it
  tried to dereference a null pointer which mod_perl had registered as a
  child cleanup hander.
  
  The patch below fixes this, and the server now starts and runs
  correctly, even with a dynamically loaded mod_perl."
  
  [ Michael Shields <sh...@crosslink.net>
    Message-ID: <13...@aluminum.crosslink.net> ]
  
  Revision  Changes    Path
  1.175     +3 -0      modperl/Changes
  
  Index: Changes
  ===================================================================
  RCS file: /home/cvs/modperl/Changes,v
  retrieving revision 1.174
  retrieving revision 1.175
  diff -u -r1.174 -r1.175
  --- Changes	1998/10/05 22:24:08	1.174
  +++ Changes	1998/10/15 08:44:45	1.175
  @@ -8,6 +8,9 @@
   
   =item 1.16_01-dev
   
  +Segfaults when build with Ben-SSL 1.27, and trying to exec the gcache.
  +[ Michael Shields <sh...@crosslink.net> ]
  +
   Fixes for a clean compile with mod_ssl [ Salvador Ortiz Garcia
   <so...@msg.com.mx> ]
   
  
  
  
  1.53      +1 -1      modperl/src/modules/perl/mod_perl.c
  
  Index: mod_perl.c
  ===================================================================
  RCS file: /home/cvs/modperl/src/modules/perl/mod_perl.c,v
  retrieving revision 1.52
  retrieving revision 1.53
  diff -u -r1.52 -r1.53
  --- mod_perl.c	1998/10/01 03:21:45	1.52
  +++ mod_perl.c	1998/10/15 08:44:46	1.53
  @@ -690,7 +690,7 @@
       Apache__ServerStarting(FALSE);
   #if MODULE_MAGIC_NUMBER >= MMN_130
       if(perl_module.dynamic_load_handle) 
  -	register_cleanup(p, NULL, mp_dso_unload, NULL); 
  +	register_cleanup(p, NULL, mp_dso_unload, null_cleanup); 
   #endif
   }