[jira] [Commented] (ARTEMIS-3823) Connection router - consistent hash modulo needs to deal with negative hash values

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534212#comment-17534212 ] 

ASF subversion and git services commented on ARTEMIS-3823:
----------------------------------------------------------

Commit d433f3bc3f0f74f857b7dafab641f46da3f275eb in activemq-artemis's branch refs/heads/main from Gary Tully
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=d433f3bc3f ]

ARTEMIS-3823 - limit modulo operation to positive hash values


> Connection router - consistent hash modulo needs to deal with negative hash values
> ----------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-3823
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3823
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: balancer
>    Affects Versions: 2.22.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>            Priority: Major
>             Fix For: 2.23.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The connection router consistent hash modulo key transformer does not work well if the hash produced a negative value.
> It makes matching more difficult to configure b/c both -1 and 1 need to be matched for a broker ordinal 1.
>  
> it would be better if the modulo was confined to positive numbers,  rather than the signed remainder.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)