You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/08 11:21:05 UTC
[GitHub] [spark] LuciferYang opened a new pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
LuciferYang opened a new pull request #34520:
URL: https://github.com/apache/spark/pull/34520
### What changes were proposed in this pull request?
The main change of this pr is change the `replication` parameter passed into `yarn.Client.copyFileToRemote` method from `Short` to `Option[Short]` to reduce one DFS interaction if `replication` passed in is `None`.
The `FileSystem.create` will also use `getDefaultReplication` as `replication` if the parameter not passed in and in this scenario, this change will not affect the actual file creation reulst.
### Why are the changes needed?
Reduce one DFS interaction if possible
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the Jenkins or GitHub Action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34520:
URL: https://github.com/apache/spark/pull/34520#issuecomment-963172379
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49471/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34520:
URL: https://github.com/apache/spark/pull/34520#issuecomment-963079401
**[Test build #144999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144999/testReport)** for PR 34520 at commit [`22219a7`](https://github.com/apache/spark/commit/22219a717750754150fcd6946fab63b6977d0e7d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34520:
URL: https://github.com/apache/spark/pull/34520#discussion_r745321500
##########
File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
##########
@@ -391,7 +391,7 @@ private[spark] class Client(
private[yarn] def copyFileToRemote(
destDir: Path,
srcPath: Path,
- replication: Short,
+ replication: Option[Short],
Review comment:
This is a good question. Let me add one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34520:
URL: https://github.com/apache/spark/pull/34520#issuecomment-963172379
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49471/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #34520:
URL: https://github.com/apache/spark/pull/34520#issuecomment-963792920
Merged to master. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao closed pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
sunchao closed pull request #34520:
URL: https://github.com/apache/spark/pull/34520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34520:
URL: https://github.com/apache/spark/pull/34520#issuecomment-963160360
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49471/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34520:
URL: https://github.com/apache/spark/pull/34520#issuecomment-963122779
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144999/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34520:
URL: https://github.com/apache/spark/pull/34520#issuecomment-963122779
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144999/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34520:
URL: https://github.com/apache/spark/pull/34520#discussion_r745275918
##########
File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
##########
@@ -391,7 +391,7 @@ private[spark] class Client(
private[yarn] def copyFileToRemote(
destDir: Path,
srcPath: Path,
- replication: Short,
+ replication: Option[Short],
Review comment:
Do we have a test coverage for the new code path invoking `None`, @LuciferYang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34520:
URL: https://github.com/apache/spark/pull/34520#issuecomment-963111888
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49471/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34520:
URL: https://github.com/apache/spark/pull/34520#issuecomment-963097985
**[Test build #144999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144999/testReport)** for PR 34520 at commit [`22219a7`](https://github.com/apache/spark/commit/22219a717750754150fcd6946fab63b6977d0e7d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34520:
URL: https://github.com/apache/spark/pull/34520#discussion_r745321500
##########
File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
##########
@@ -391,7 +391,7 @@ private[spark] class Client(
private[yarn] def copyFileToRemote(
destDir: Path,
srcPath: Path,
- replication: Short,
+ replication: Option[Short],
Review comment:
This is a good question. Looks like `any()` can't cover `None`, let me add one later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34520: [SPARK-37239][YARN] Avoid call `setReplication` if yarn Client uploading resource use default replication value
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34520:
URL: https://github.com/apache/spark/pull/34520#issuecomment-963079401
**[Test build #144999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144999/testReport)** for PR 34520 at commit [`22219a7`](https://github.com/apache/spark/commit/22219a717750754150fcd6946fab63b6977d0e7d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org