You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "spark shen (JIRA)" <ji...@apache.org> on 2006/08/02 04:24:13 UTC

[jira] Created: (HARMONY-1037) [classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value

[classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value
-------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-1037
                 URL: http://issues.apache.org/jira/browse/HARMONY-1037
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: spark shen


When using time zone "Europe/London" and Locale("en", "GB")
or time zone "Europe/London" and Locale("fr"),
java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return
correct value. The expected return value is 4, but on harmony, the returned value
is 1.

The following test case gives a hint.
public void test_getMinimalDaysInFirstWeek() {

        GregorianCalendar g = new GregorianCalendar(TimeZone
                .getTimeZone("Europe/London"), new Locale("en", "GB"));
        int minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
        assertEquals(4, minimalDaysInFirstWeek);

        g = new GregorianCalendar(TimeZone.getTimeZone("Europe/London"),
                new Locale("fr"));
        minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
        assertEquals(4, minimalDaysInFirstWeek);
    }

Test case passes on RI
          fails  on Harmony

I will attach a patch to fix this problem.
Spark Shen,
Best regards

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-1037) [classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1037?page=all ]

Paulex Yang reassigned HARMONY-1037:
------------------------------------

    Assignee: Paulex Yang

> [classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1037
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1037
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: spark shen
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1037.diff
>
>
> When using time zone "Europe/London" and Locale("en", "GB")
> or time zone "Europe/London" and Locale("fr"),
> java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return
> correct value. The expected return value is 4, but on harmony, the returned value
> is 1.
> The following test case gives a hint.
> public void test_getMinimalDaysInFirstWeek() {
>         GregorianCalendar g = new GregorianCalendar(TimeZone
>                 .getTimeZone("Europe/London"), new Locale("en", "GB"));
>         int minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
>         assertEquals(4, minimalDaysInFirstWeek);
>         g = new GregorianCalendar(TimeZone.getTimeZone("Europe/London"),
>                 new Locale("fr"));
>         minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
>         assertEquals(4, minimalDaysInFirstWeek);
>     }
> Test case passes on RI
>           fails  on Harmony
> I will attach a patch to fix this problem.
> Spark Shen,
> Best regards

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-1037) [classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value

Posted by "spark shen (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-1037?page=comments#action_12426471 ] 
            
spark shen commented on HARMONY-1037:
-------------------------------------

Hi Paulex,
The patch looks fine. Thank you.

Best regards
Spark Shen

> [classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1037
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1037
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: spark shen
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1037.diff
>
>
> When using time zone "Europe/London" and Locale("en", "GB")
> or time zone "Europe/London" and Locale("fr"),
> java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return
> correct value. The expected return value is 4, but on harmony, the returned value
> is 1.
> The following test case gives a hint.
> public void test_getMinimalDaysInFirstWeek() {
>         GregorianCalendar g = new GregorianCalendar(TimeZone
>                 .getTimeZone("Europe/London"), new Locale("en", "GB"));
>         int minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
>         assertEquals(4, minimalDaysInFirstWeek);
>         g = new GregorianCalendar(TimeZone.getTimeZone("Europe/London"),
>                 new Locale("fr"));
>         minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
>         assertEquals(4, minimalDaysInFirstWeek);
>     }
> Test case passes on RI
>           fails  on Harmony
> I will attach a patch to fix this problem.
> Spark Shen,
> Best regards

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-1037) [classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1037?page=all ]

Paulex Yang resolved HARMONY-1037.
----------------------------------

    Resolution: Fixed

Spark, patch applied at revision r427909, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.


> [classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1037
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1037
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: spark shen
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1037.diff
>
>
> When using time zone "Europe/London" and Locale("en", "GB")
> or time zone "Europe/London" and Locale("fr"),
> java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return
> correct value. The expected return value is 4, but on harmony, the returned value
> is 1.
> The following test case gives a hint.
> public void test_getMinimalDaysInFirstWeek() {
>         GregorianCalendar g = new GregorianCalendar(TimeZone
>                 .getTimeZone("Europe/London"), new Locale("en", "GB"));
>         int minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
>         assertEquals(4, minimalDaysInFirstWeek);
>         g = new GregorianCalendar(TimeZone.getTimeZone("Europe/London"),
>                 new Locale("fr"));
>         minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
>         assertEquals(4, minimalDaysInFirstWeek);
>     }
> Test case passes on RI
>           fails  on Harmony
> I will attach a patch to fix this problem.
> Spark Shen,
> Best regards

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-1037) [classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1037?page=all ]

Paulex Yang closed HARMONY-1037.
--------------------------------


Verified by Spark.

> [classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1037
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1037
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: spark shen
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1037.diff
>
>
> When using time zone "Europe/London" and Locale("en", "GB")
> or time zone "Europe/London" and Locale("fr"),
> java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return
> correct value. The expected return value is 4, but on harmony, the returned value
> is 1.
> The following test case gives a hint.
> public void test_getMinimalDaysInFirstWeek() {
>         GregorianCalendar g = new GregorianCalendar(TimeZone
>                 .getTimeZone("Europe/London"), new Locale("en", "GB"));
>         int minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
>         assertEquals(4, minimalDaysInFirstWeek);
>         g = new GregorianCalendar(TimeZone.getTimeZone("Europe/London"),
>                 new Locale("fr"));
>         minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
>         assertEquals(4, minimalDaysInFirstWeek);
>     }
> Test case passes on RI
>           fails  on Harmony
> I will attach a patch to fix this problem.
> Spark Shen,
> Best regards

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-1037) [classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value

Posted by "spark shen (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1037?page=all ]

spark shen updated HARMONY-1037:
--------------------------------

    Attachment: Harmony-1037.diff

Would you please try this patch?

Spark Shen
Best regard

> [classlib][luni] java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return correct value
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1037
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1037
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: spark shen
>         Attachments: Harmony-1037.diff
>
>
> When using time zone "Europe/London" and Locale("en", "GB")
> or time zone "Europe/London" and Locale("fr"),
> java.util.GregorianCalendar.getMinimalDaysInFirstWeek() method does not return
> correct value. The expected return value is 4, but on harmony, the returned value
> is 1.
> The following test case gives a hint.
> public void test_getMinimalDaysInFirstWeek() {
>         GregorianCalendar g = new GregorianCalendar(TimeZone
>                 .getTimeZone("Europe/London"), new Locale("en", "GB"));
>         int minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
>         assertEquals(4, minimalDaysInFirstWeek);
>         g = new GregorianCalendar(TimeZone.getTimeZone("Europe/London"),
>                 new Locale("fr"));
>         minimalDaysInFirstWeek = g.getMinimalDaysInFirstWeek();
>         assertEquals(4, minimalDaysInFirstWeek);
>     }
> Test case passes on RI
>           fails  on Harmony
> I will attach a patch to fix this problem.
> Spark Shen,
> Best regards

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira