You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by karanmehta93 <gi...@git.apache.org> on 2018/08/07 17:13:36 UTC
[GitHub] phoenix pull request #322: PHOENIX-4834 PhoenixMetricsLog interface methods ...
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/322
PHOENIX-4834 PhoenixMetricsLog interface methods should not depend on…
… specific logger
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karanmehta93/phoenix 4.x-HBase-1.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #322
----
commit 656567cba78cafda0540bddfe0f5070939be9155
Author: Karan Mehta <ka...@...>
Date: 2018-08-07T17:12:42Z
PHOENIX-4834 PhoenixMetricsLog interface methods should not depend on specific logger
----
---
[GitHub] phoenix issue #322: PHOENIX-4834 PhoenixMetricsLog interface methods should ...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/322
Ditto, Shipit!
---
[GitHub] phoenix issue #322: PHOENIX-4834 PhoenixMetricsLog interface methods should ...
Posted by karanmehta93 <gi...@git.apache.org>.
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/322
@joshelser @twdsilva Please review.
---
[GitHub] phoenix pull request #322: PHOENIX-4834 PhoenixMetricsLog interface methods ...
Posted by karanmehta93 <gi...@git.apache.org>.
Github user karanmehta93 closed the pull request at:
https://github.com/apache/phoenix/pull/322
---
[GitHub] phoenix issue #322: PHOENIX-4834 PhoenixMetricsLog interface methods should ...
Posted by twdsilva <gi...@git.apache.org>.
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/322
+1
---